Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Upgrade: dmlc::optional<T> constructors and value() function #20560

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Upgrade: dmlc::optional<T> constructors and value() function #20560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ed94ab4
Upgrade: dmlc::optional<T> ctors
mozga-intel Sep 1, 2021
a7dc50b
Tuple.h update
mozga-intel Sep 1, 2021
dd36c90
The size of stack is greater
mozga-intel Sep 2, 2021
f00b40a
Set default value
mozga-intel Sep 2, 2021
6dce172
Parametr should not be emptty
mozga-intel Sep 2, 2021
577ce58
Variable mighe be uninitialized - skip the error message
mozga-intel Sep 3, 2021
f1860d6
Zero initialization
mozga-intel Sep 3, 2021
3abb766
Tuple, the size of a buffer is equal: 20
mozga-intel Sep 6, 2021
16899b6
DMLC update commit
mozga-intel Sep 6, 2021
682a459
The size of a stack is being set on 6
mozga-intel Sep 8, 2021
34d1115
The size of a stack needs to be equal to 8
mozga-intel Sep 8, 2021
3c2398c
Merge remote-tracking branch 'origin/master' into mozga-intel/optiona…
mozga-intel Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 3rdparty/dmlc-core
Open in desktop
Submodule dmlc-core updated 1 files
+160 −24 include/dmlc/optional.h
2 changes: 1 addition & 1 deletion 3rdparty/tvm
Open in desktop
Submodule tvm updated from efdac9 to 07e81c
2 changes: 1 addition & 1 deletion include/mxnet/tuple.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ class Tuple {

protected:
// stack cache size
static const int kStackCache = 4;
static const int kStackCache = 8;
/*! \brief number of dimension of the tuple */
int ndim_{0};
/*! \brief number of cells allocated in data_heap_ */
Expand Down
4 changes: 2 additions & 2 deletions src/operator/numpy/random/np_choice_op.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ struct NumpyChoiceParam : public dmlc::Parameter<NumpyChoiceParam> {
bool replace;
bool weighted;
DMLC_DECLARE_PARAMETER(NumpyChoiceParam) {
DMLC_DECLARE_FIELD(a);
DMLC_DECLARE_FIELD(size);
DMLC_DECLARE_FIELD(a).set_default(dmlc::optional<int64_t>());
DMLC_DECLARE_FIELD(size).set_default(dmlc::optional<mxnet::Tuple<int64_t>>());
DMLC_DECLARE_FIELD(ctx).set_default("cpu");
DMLC_DECLARE_FIELD(replace).set_default(true);
DMLC_DECLARE_FIELD(weighted).set_default(false);
Expand Down