Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Master] The size of a stack needs to be greater than 4 #20581

Merged

Conversation

mozga-intel
Copy link
Contributor

@mozga-intel mozga-intel commented Sep 15, 2021

Description

The size of a stack is always 4. A new optional (#658) structure is used to indicate that an object t may be "moved from" ~ allowing the efficient transfer of resources from t to another object. If an old value is moved into a new object, then the size is not enough and a blind value is reading out of the memory ~ hence: a double corruption error shows up. The size of the stack needs to be greater to avoid double corruption errors. The issue comes from #20560.

In this scenario: if a previous container is moved into a new buffer, then an address of a buffer is the same.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, website, edge, unix-cpu, sanity, windows-cpu, windows-gpu, clang, centos-gpu, unix-gpu, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Sep 15, 2021
@mozga-intel mozga-intel changed the title The size of a stack needs to be greater than 4 [Master] The size of a stack needs to be greater than 4 Sep 15, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 15, 2021
@mozga-intel
Copy link
Contributor Author

@mxnet-bot run ci [website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 15, 2021
@mozga-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 15, 2021
@szha szha merged commit 3507db2 into apache:master Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants