Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1358][Fit API] Fit api tutorial #14462

Closed
wants to merge 164 commits into from

Conversation

piyushghai
Copy link
Contributor

@piyushghai piyushghai commented Mar 18, 2019

Description

Added a simple tutorial showcasing the fit api usage.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)

Related PR for assets for the tutorial --> dmlc/web-data#171

@roywei @abhinavs95 @karan6181

@piyushghai piyushghai requested a review from szha as a code owner March 18, 2019 23:01
@piyushghai piyushghai changed the title [MXNET-1358] Fit api tutorial [MXNET-1358][Fit API] Fit api tutorial Mar 18, 2019
@piyushghai
Copy link
Contributor Author

@mxnet-label-bot Add [Gluon, pr-awaiting-review]

@marcoabreu marcoabreu added Gluon pr-awaiting-review PR is waiting for code review labels Mar 18, 2019
@piyushghai piyushghai force-pushed the fit-api branch 2 times, most recently from b9ede39 to 3e4e9db Compare March 18, 2019 23:11
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
@piyushghai
Copy link
Contributor Author

Will address the feedback and will post an update on it.
Closing this PR for now.

@piyushghai piyushghai closed this Mar 19, 2019
@piyushghai piyushghai reopened this Mar 19, 2019
@piyushghai
Copy link
Contributor Author

@ThomasDelteil Can you also review this :) ?

docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
@abhinavs95
Copy link
Contributor

@ThomasDelteil could you please have a look and see if your comments are addressed? thanks

Copy link
Contributor

@thomelane thomelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @piyushghai (@roywei)! It makes MXNet a whole load more accessible to beginners users, so I'd expect a flood load of readers on this tutorial. Given this, I've been a bit more particular with my review here, so please excuse all of the nits. :)

docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
@roywei roywei mentioned this pull request Apr 5, 2019
5 tasks
@piyushghai piyushghai changed the title [MXNET-1358][Fit API] Fit api tutorial [MXNET-1358][DO NOT MERGE][Fit API] Fit api tutorial Apr 5, 2019
xinyu-intel and others added 23 commits June 13, 2019 11:08
* Fix cached op

Change-Id: If90c6f0997548ffd5daa67cc18bab7405f24213b

* Fix UT

* trigger
…15197)

* Updated Image Augmentation tutorial to use Transforms.

* Updates based on feedback.
* Cleaned up profiling tutorial.

* Minor edits to profiler tutorial.

* fix ascii issue

* Updates based on feedback.
* Add multiple GPUs training tutorial

* Add download source button

* Add tutorial to the test suite

* Remove from nightly build (no CI multigpu machines)

* Add extension to whitelisted multigpu tutorial

* Force build

* Force update

* Code review fixes

* Force build

* Typo fix and force build

* Add tutorial back to tests

* Add tutorial to the index

* Force build
…ache#15177)

* add MXEnginePushAsyncND and MXEnginePushSyncND

* fix test build

* return exception value

* retrigger CI
* add support for sorting and printing aggregate info in json

* revert some overwrites

* revert to old c apis; added MXAggregateProfileStatsPrintEx instead

* style fix

* style fixes

* more style fixes

* rebase

* style fixes

* fix infinite loop bug

* test cases added and bugs fixed

* fix test cases

* fix testcases

* testcases

* testcases

* testcases

* fix doc

* use enum to avoid hardcoding

* sanity test fix

* sanity test fix

* add parameter validation

* add parameter validation in frontend

* validation

* removing print()

* fix typos
* Fix nightly build warning

* Force build
* bump up cudnn version

* downgrade tensorRT to 7.5

* bump up NCCL 2.4.7
* fix horovod build when mxnet is built from source

* copy header file in mkldnn

* copy mkldnn_version header file to include

* remove unnecessary line

* fix the untracked file

* whitelist mkldnn headerfile

* exlude lint path
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Gluon pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.