Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Updated Image Augmentation tutorial to use Gluon Transforms. #15197

Merged
merged 2 commits into from
Jun 13, 2019

Conversation

thomelane
Copy link
Contributor

Description

Data Augmentation tutorial used Augmenters rather than Gluon Transforms. Updates have to been made to the tutorial to use Transforms, and new images have been hosted on web-data repository.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@thomelane thomelane requested a review from szha as a code owner June 10, 2019 18:48
@vandanavk
Copy link
Contributor

@mxnet-label-bot add [Doc, pr-awaiting-review]

@marcoabreu marcoabreu added Doc pr-awaiting-review PR is waiting for code review labels Jun 10, 2019
Copy link
Contributor

@vishaalkapoor vishaalkapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Data transforms tutorial pending? LGTM after changes.

docs/tutorials/gluon/data_augmentation.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/data_augmentation.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/data_augmentation.md Show resolved Hide resolved
docs/tutorials/gluon/data_augmentation.md Show resolved Hide resolved
docs/tutorials/gluon/data_augmentation.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/data_augmentation.md Show resolved Hide resolved
@vishaalkapoor
Copy link
Contributor

Pending changes, LGTM.

@thomelane
Copy link
Contributor Author

thanks @vishaalkapoor, made changes as suggested.

@vishaalkapoor
Copy link
Contributor

LGTM!

@ThomasDelteil ThomasDelteil merged commit b58cf0a into apache:master Jun 13, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
…15197)

* Updated Image Augmentation tutorial to use Transforms.

* Updates based on feedback.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants