This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Cleaned up profiling tutorial #15228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/tutorials/python/profiler.md
Outdated
| From the output above, it seems as if printing the output takes lot more time that multiplying two large matrices. That doesn't feel right. | ||
|
|
||
| This is because, in MXNet, all operations are executed asynchronously. So, when `nd.dot(x, x)` returns, the matrix multiplication is not complete, it has only been queued for execution. `asnumpy` in `print(y.asnumpy())` however, waits for the result to be computed and hence takes longer time. | ||
| This is because, in MXNet, all operations are executed asynchronously. So, when `nd.dot(x, x)` returns, the matrix multiplication is not complete, it has only been queued for execution. `asnumpy` however, waits for the result to be computed and hence takes longer time. Other examples of 'blocking' operations include `asscalar` and `wait_to_read`. |
There was a problem hiding this comment.
asnumpy however, has to wait for the result to be actually computed in order to be able to convert it to a numpy array on CPU, hence taking a longer time.
or something like that. To express that it doesn't just wait for no reason.
There was a problem hiding this comment.
great point. added.
|
@mxnet-label-bot add [pr-awaiting-review, Doc] |
|
thanks for the review @vishaalkapoor! |
|
LGTM! |
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Cleaned up profiling tutorial. * Minor edits to profiler tutorial. * fix ascii issue * Updates based on feedback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed wording of a few parts of the tutorial.
Added more description around NVidia Profiling tools (for beginners).
Moved images to web-data (and now link there).
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments