Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1358]Fit api tutorial #15353

Merged
merged 28 commits into from
Aug 1, 2019
Merged

[MXNET-1358]Fit api tutorial #15353

merged 28 commits into from
Aug 1, 2019

Conversation

roywei
Copy link
Member

@roywei roywei commented Jun 25, 2019 •
edited by aaronmarkham
Loading

Description

  1. bring back [MXNET-1358][Fit API] Fit api tutorial #14462
    main contributor @piyushghai
    I have updated the tutorial to the latest fit/estimator api
  2. update website API generation( add to API index, fixed imports for automated API doc generation)
  3. fixed checkpoint reuqires hybridization

@ThomasDelteil @thomelane @aaronmarkham

Preview

@roywei roywei requested a review from szha as a code owner June 25, 2019 11:07
aaronmarkham
aaronmarkham suggested changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar, spelling, and clarity check. I didn't get a chance to run this.

docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Show resolved Hide resolved
@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jun 28, 2019
@roywei roywei mentioned this pull request Jul 16, 2019
Merged
@roywei
Copy link
Member Author

roywei commented Jul 16, 2019 •
edited
Loading

@aaronmarkham I have addressed your comments, could you take another look? thanks!
Another problem is the estimator API doc is not showing up on the website, not sure if this will fix it. It should be automatically picked up by website?

Added from . import estimator in file python/mxnet/gluon/contrib/__init__.py

abhinavs95
abhinavs95 reviewed Jul 24, 2019
View reviewed changes
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
docs/tutorials/gluon/fit_api_tutorial.md Outdated Show resolved Hide resolved
@eric-haibin-lin
Copy link
Member

any update on this ? mxnet 1.5 is released but no doc for the feature.

@roywei
Copy link
Member Author

roywei commented Jul 29, 2019

I have addressed commend @aaronmarkham @abhinavs95 could you take another look? Thanks

@roywei
Copy link
Member Author

roywei commented Jul 31, 2019 •
edited
Loading

I have verified the documentation is successfully generated, tutorial is passing, nightly tests are passing and unit tests should be already checked by CI

ping @aaronmarkham for review on the docs. Thanks!

estimator
checkpoint

aaronmarkham
aaronmarkham approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@roywei
Copy link
Member Author

roywei commented Aug 1, 2019

Update website API docs can be found at: http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-15353/10/api/python/gluon/contrib.html

Tutorial: http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-15353/10/tutorials/gluon/fit_api_tutorial.html

@eric-haibin-lin eric-haibin-lin merged commit 4b07386 into apache:master Aug 1, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
@roywei
[MXNET-1358] Fit api tutorial (apache#15353)
a7fc95a 
* Added tutorial for FIT API

* Added tests for Fit API tutorial

* Updated index.md for the new tutorial to show up

* Addressed PR feedback

* Addressed PR feedback

* Removed spurious comment for Py2 and Py3 compatibility

* Address PR feedback

* Addressed PR feedback

* Fixed typo

* Added example to showcase custom event handler

* Fixed imports as estimator moved to contrib package

* Added a side note to inform about estimator reference being updated by the handlers

* Corrected typo

* update tutorial

* address comments

* new line

* fix import

* fix cached graph

* fix import

* address comments

* fix doc gen

* add softmax

* add to website index

* fix doc string

* Fix doc gen (apache#12)

* fix warining

* fix test

* fix

* fix

* fix print

* fix test (apache#13)

* fix warning (apache#14)

* fix href (apache#15)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abhinavs95 abhinavs95 abhinavs95 left review comments

@aaronmarkham aaronmarkham aaronmarkham approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin

@marcoabreu marcoabreu Awaiting requested review from marcoabreu

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@roywei @anirudhacharya @eric-haibin-lin @aaronmarkham @abhinavs95 @marcoabreu @piyushghai