This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
add cpp example inception to nightly test #13534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-testing] |
marcoabreu
added
the
pr-awaiting-testing
sandeep-krishnamurthy
added
pr-awaiting-merge
|
CI passed, but found out mlp test took a long time, changed max epochs to 10 to align with mlp_gpu, mlp_cpu examples. |
lupesko
suggested changes
Dec 5, 2018
cpp-package/example/mlp.cpp
Outdated
| @@ -144,7 +144,7 @@ void MLP() { | |||
| grad_req_type, aux_states); | |||
|
|
|||
| std::cout << "Training" << std::endl; | |||
| int max_iters = 20000; | |||
| int max_iters = 10; | |||
There was a problem hiding this comment.
You are reducing max_iters to 10, but you did not change line 152 which has an if (iter % 100 == 0)
If you want to run for 10 epochs only I think you can remove the if condition on line 152.
I also suggest to rename iter to epochNum for readability.
There was a problem hiding this comment.
addressed comments and turns out it's iterating on a synthetic patterned data of size 128, it will take around 15000 epochs to get 90% acc. Renamed the variables and added comment
zhaoyao73
pushed a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
* add inception test * fix max iter for mlp * rename and add comment * rename epoch num
zhaoyao73
added a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
* upstream/master: (54 commits) Add notes about debug with libstdc++ symbols (apache#13533) add cpp example inception to nightly test (apache#13534) Fix exception handling api doc (apache#13519) fix link for gluon model zoo (apache#13583) ONNX import/export: Size (apache#13112) Update MXNetTutorialTemplate.ipynb (apache#13568) fix the situation where idx didn't align with rec (apache#13550) Fix use-before-assignment in convert_dot (apache#13511) License update (apache#13565) Update version to v1.5.0 including clojure package (apache#13566) Fix flaky test test_random:test_randint_generator (apache#13498) Add workspace cleaning after job finished (apache#13490) Adding test for softmaxoutput (apache#13116) apache#13441 [Clojure] Add Spec Validations for the Random namespace (apache#13523) Revert "Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file" (apache#13558) Chi_square_check for discrete distribution fix (apache#13543) Updated docs for randint operator (apache#13541) Simplifications and some fun stuff for the MNIST Gluon tutorial (apache#13094) Fix apache#13521 (apache#13537) Add a retry to qemu_provision (apache#13551) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
replace #13367
a follow up to add inception into nightly test after fix in #13284
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments