Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Example] add cpp inception in Jenkins and nightly test #13367

Closed
wants to merge 3 commits into from

Conversation

roywei
Copy link
Member

@roywei roywei commented Nov 22, 2018

Description

Depends on #13284 to be merged and code freeze on Jenkins file.

As we are having major refractors on CI and Jenkins files, I am separating adding unit test and change Jenkins file from #13284 out, so it can be merged.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Add inception in Jenkins
Add inception in unit tests

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@stu1130 stu1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stu1130
Copy link
Contributor

stu1130 commented Nov 22, 2018

@mxnet-label-bot add [pr-awaiting-review]
Thanks for your contribution @roywei

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Nov 22, 2018
@marcoabreu
Copy link
Contributor

please wait with changes to the Jenkinsfile until further notice

@vandanavk
Copy link
Contributor

@mxnet-label-bot update [pr-awaiting-testing]

@marcoabreu marcoabreu added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Nov 28, 2018
@roywei
Copy link
Member Author

roywei commented Nov 29, 2018

@marcoabreu can we change Jenkins file now? It's small change to compile inception_bn example, so it can be tested nightly.

@roywei
Copy link
Member Author

roywei commented Dec 4, 2018

closing this as Jenkinsfiles changed a lot and adding cpp test does not require changing Jekins file anymore

@roywei roywei closed this Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-testing PR is reviewed and waiting CI build and test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants