This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Example] fix cpp example inception-bn and training acc issue #13284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roywei
changed the title
5 tasks
stu1130
reviewed
Nov 15, 2018
| @@ -172,7 +173,13 @@ int main(int argc, char const *argv[]) { | |||
| auto val_iter = MXDataIter("MNISTIter"); | |||
| setDataIter(&val_iter, "Label", data_files, batch_size); | |||
|
|
|||
| Optimizer* opt = OptimizerRegistry::Find("ccsgd"); | |||
There was a problem hiding this comment.
is there any reason to change the optimizer?
cpp-package/tests/ci_test.sh
Outdated
| @@ -36,6 +36,9 @@ cp ../../build/cpp-package/example/lenet_with_mxdataiter . | |||
| cp ../../build/cpp-package/example/resnet . | |||
| ./resnet 5 | |||
|
|
|||
| cp ../../build/cpp-package/example/resnet . | |||
| ./inception-bn 5 | |||
|
|
|||
| cp ../../build/cpp-package/example/mlp . | |||
There was a problem hiding this comment.
should we also add the mlp_csv example here?
There was a problem hiding this comment.
@stu1130 ccsgd was deprecated long time ago, actually, I will update to change ccsgd in all other examples.
|
@roywei please take a look at the failed CI and re-trigger it |
|
@mxnet-label-bot add [pr-awaiting-review] |
|
@marcoabreu according to dev list discussion, this PR will be blocked by #13344 as it's changing Jenkins file |
nswamy
reviewed
Nov 21, 2018
5 tasks
This was referenced Dec 4, 2018
This was referenced Jan 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: [cpp-package] inception_bn.cpp is wrong #9417
Root Cause:
Passing correct padding (1, 1) in Pooling in InceptionFactoryB
Reference python implementation,
pad=(1, 1)Tested example working fine.
fix some models not training: CPP examples training acc does not increase #13243, Strange behaviour/possible bug with mxnet::cpp::Symbol::Variable name argument #12966, [C++] Some Variable Name cause no Gradient #8108
Root Cause:
Wrong logic for gradient requirement: symbols with name length 3 and 4 won't have gradients
Changed to:
Symbols names contains "data" or "label" should not be required for gradients
Added parameter initialization same as python versions
added inception-bn to unit tests
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
see description
Comments