This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Clojure] Add Spec Validations for the Random namespace #13441
Labels
Comments
hellonico
added a commit
to hellonico/incubator-mxnet
that referenced
this issue
Dec 4, 2018
hellonico
added a commit
to hellonico/incubator-mxnet
that referenced
this issue
Dec 5, 2018
hellonico
added a commit
to hellonico/incubator-mxnet
that referenced
this issue
Dec 6, 2018
hellonico
added a commit
to hellonico/incubator-mxnet
that referenced
this issue
Dec 6, 2018
|
Thanks @hellonico ! |
gigasquid
pushed a commit
that referenced
this issue
Dec 6, 2018
zhaoyao73
pushed a commit
to zhaoyao73/incubator-mxnet
that referenced
this issue
Dec 13, 2018
zhaoyao73
added a commit
to zhaoyao73/incubator-mxnet
that referenced
this issue
Dec 13, 2018
* upstream/master: (54 commits) Add notes about debug with libstdc++ symbols (apache#13533) add cpp example inception to nightly test (apache#13534) Fix exception handling api doc (apache#13519) fix link for gluon model zoo (apache#13583) ONNX import/export: Size (apache#13112) Update MXNetTutorialTemplate.ipynb (apache#13568) fix the situation where idx didn't align with rec (apache#13550) Fix use-before-assignment in convert_dot (apache#13511) License update (apache#13565) Update version to v1.5.0 including clojure package (apache#13566) Fix flaky test test_random:test_randint_generator (apache#13498) Add workspace cleaning after job finished (apache#13490) Adding test for softmaxoutput (apache#13116) apache#13441 [Clojure] Add Spec Validations for the Random namespace (apache#13523) Revert "Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file" (apache#13558) Chi_square_check for discrete distribution fix (apache#13543) Updated docs for randint operator (apache#13541) Simplifications and some fun stuff for the MNIST Gluon tutorial (apache#13094) Fix apache#13521 (apache#13537) Add a retry to qemu_provision (apache#13551) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It would be nice to add some spec validations to the random namespace https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/src/org/apache/clojure_mxnet/random.clj
So that if a user calls a function with the incorrect arguments, it will guide them to the correct form.
Using the
util/validatefunction as in https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/src/org/apache/clojure_mxnet/module.clj#L186 and the correct specs would be a great addition to the project.Addition of unit tests to test a failing case of the spec that an exception is thrown would be great too :)
The text was updated successfully, but these errors were encountered: