MINOR: improve tests for TopologyTestDriver#8631
Merged
Merged
Conversation
vvcephei
approved these changes
May 8, 2020
Member
Author
|
Java 8 passed. Retest this please. |
Member
Author
|
Retest this please. (Ok. Maybe next week...) |
Member
Author
|
Retest this please |
big-andy-coates
approved these changes
May 12, 2020
big-andy-coates
left a comment
big-andy-coates
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mjsax LGTM
| } | ||
|
|
||
| @Test | ||
| public void shouldCaptureGlobalTopicNameIfWrittenInto() { |
Contributor
There was a problem hiding this comment.
Would this test still pass, even without the global table?
Member
Author
There was a problem hiding this comment.
Yes, the SOURCE_TOPCI_1 should be added to the set of produced topics in any case. It's more like a "reverse" check, i.e., that it does not fail with a to() operation that reuses the "global topic name".
I was not 100% sure if this test is strictly necessary, but thought it can't hurt either.
Kvicii
added a commit
to Kvicii/kafka
that referenced
this pull request
May 14, 2020
* 'trunk' of github.com:apache/kafka: MINOR: add option to rebuild source for system tests (apache#6656) KAFKA-9850 Move KStream#repartition operator validation during Topolo… (apache#8550) MINOR: Add a duplicate() method to Message classes (apache#8556) KAFKA-9966: add internal assignment listener to stabilize eos-beta upgrade test (apache#8648) MINOR: Replace null with an actual value for timestamp field in InsertField SMT unit tests (apache#8649) MINOR: Fix ProcessorContext JavaDocs and stream-time computation (apache#8603) MINOR: improve tests for TopologyTestDriver (apache#8631) KAFKA-9821: consolidate Streams rebalance triggering mechanisms (apache#8596) KAFKA-9669; Loosen validation of inner offsets for older message formats (apache#8647) KAFKA-8770: KIP-557: Drop idempotent KTable source updates (apache#8254) MINOR: Remove allow concurrent test (apache#8641)
jwijgerd
pushed a commit
to buxapp/kafka
that referenced
this pull request
May 14, 2020
Reviewers: John Roesler <john@confluent.io>, Andy Coates <andy@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8483 (in particular #8483 (comment))
Call for review @big-andy-coates @vvcephei