MINOR: Add option to rebuild source for system tests#6656
Conversation
|
Retest this please |
1 similar comment
|
Retest this please |
|
@mjsax @hachikuji Could you take a look when you got time? |
|
@mjsax Could we get this merged? |
There was a problem hiding this comment.
Not sure it's safe to depend of the local directory. Perhaps it should be relative to $SCRIPT_DIR?
I am also not too sure a prompt is the best way. If we have any automated systems using this script, it would fail, right? Could we pass an optional flag instead? Something like --rebuild which defaults to false?
|
@hachikuji Addressed comment. Note that it's not required to change directory because the script has to be run under Kafka root when triggered by human user. |
|
Retest this please |
1 similar comment
|
Retest this please |
|
@mjsax Could we merge this? |
|
@hachikuji if you are happy with this PR, feel free to merge. |
|
@hachikuji WDYT? |
* 'trunk' of github.com:apache/kafka: MINOR: add option to rebuild source for system tests (apache#6656) KAFKA-9850 Move KStream#repartition operator validation during Topolo… (apache#8550) MINOR: Add a duplicate() method to Message classes (apache#8556) KAFKA-9966: add internal assignment listener to stabilize eos-beta upgrade test (apache#8648) MINOR: Replace null with an actual value for timestamp field in InsertField SMT unit tests (apache#8649) MINOR: Fix ProcessorContext JavaDocs and stream-time computation (apache#8603) MINOR: improve tests for TopologyTestDriver (apache#8631) KAFKA-9821: consolidate Streams rebalance triggering mechanisms (apache#8596) KAFKA-9669; Loosen validation of inner offsets for older message formats (apache#8647) KAFKA-8770: KIP-557: Drop idempotent KTable source updates (apache#8254) MINOR: Remove allow concurrent test (apache#8641)
Reviewers: Jason Gustafson <jason@confluent.io>, Matthias J. Sax <matthias@confluent.io>
4 participants
Save developer time for running mandatory commands.
Committer Checklist (excluded from commit message)