KAFKA-9850 Move KStream#repartition operator validation during Topolo…#8550
Merged
Conversation
abbccdda
reviewed
Apr 26, 2020
abbccdda
left a comment
abbccdda
left a comment
There was a problem hiding this comment.
Thanks for the PR, get some comments.
Contributor
Author
|
@abbccdda Hi, pr updated. Could you continue to review it? |
mjsax
reviewed
May 2, 2020
| .collect(Collectors.toSet()) | ||
| ).collect(Collectors.toList()); | ||
| for (final Set<String> copartition : copartitionGroups) { | ||
| final Map<String, Integer> topicPartNum = new HashMap<>(); |
Member
There was a problem hiding this comment.
What is topicPartNum? Please avoid abbreviation; make the code hard to read?
Should this be numberOfPartitionsPerTopic ?
Contributor
Author
There was a problem hiding this comment.
Done and thanks for your advice.
Member
|
Retest this please. |
Contributor
Author
@mjsax I have modified the codes according to your suggestion and passed the test. Could you continue to review it? |
Member
|
Thanks for the update. I'll wait for Jenkins and do another pass afterwards. Btw: the comment "Retest this please" is not for you, but for Jenkins to run the build :) -- you can ignore those comments. (Also note, only committers can trigger builds so it won't work for you). |
Member
|
Retest this please. |
Contributor
Author
|
@mjsax hi, failed tests have been fixed. Could you retest this? |
Member
|
Retest this please. |
Member
|
Will try to review in the next couple of day. |
Contributor
Author
@mjsax could you retest this? I tested cases in my laptop and the failed case passed |
Member
|
Thanks for the PR @zhaohaidao! Merged to |
Kvicii
added a commit
to Kvicii/kafka
that referenced
this pull request
May 14, 2020
* 'trunk' of github.com:apache/kafka: MINOR: add option to rebuild source for system tests (apache#6656) KAFKA-9850 Move KStream#repartition operator validation during Topolo… (apache#8550) MINOR: Add a duplicate() method to Message classes (apache#8556) KAFKA-9966: add internal assignment listener to stabilize eos-beta upgrade test (apache#8648) MINOR: Replace null with an actual value for timestamp field in InsertField SMT unit tests (apache#8649) MINOR: Fix ProcessorContext JavaDocs and stream-time computation (apache#8603) MINOR: improve tests for TopologyTestDriver (apache#8631) KAFKA-9821: consolidate Streams rebalance triggering mechanisms (apache#8596) KAFKA-9669; Loosen validation of inner offsets for older message formats (apache#8647) KAFKA-8770: KIP-557: Drop idempotent KTable source updates (apache#8254) MINOR: Remove allow concurrent test (apache#8641)
jwijgerd
pushed a commit
to buxapp/kafka
that referenced
this pull request
May 14, 2020
apache#8550) Reviewers: Boyang Chen <boyang@confluent.io>, Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets: KAFKA-9850