KAFKA-9865: Expose output topic names from TopologyTestDriver#8483
Merged
mjsax merged 3 commits intoMay 7, 2020
Conversation
Expose the set of output topic names the topology produced records to during its test run.
Member
|
ok to test |
Contributor
|
@big-andy-coates I think you are referencing the wrong jira here :) |
mjsax
changed the title
Member
|
Fixed the PR title already. Lets wait for the KIP approval before moving forward on the PR |
mjsax
reviewed
Apr 24, 2020
Contributor
Author
|
Give a man a chance! ;)
…On Fri, 24 Apr 2020 at 18:12, Matthias J. Sax ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
<#8483 (comment)>:
> @@ -855,6 +856,20 @@ public void advanceWallClockTime(final Duration advance) {
return new TestOutputTopic<>(this, topicName, keyDeserializer, valueDeserializer);
}
+ /**
+ * Get all the names of all the topics to which records have been output.
+ * <p>
+ * Call this method after piping the input into the test driver to retrieve the full set of topics the topology
+ * produced records to.
+ * <p>
+ * The returned set of topic names includes changelog, repartition and sink topic names.
+ *
+ * @return the set of output topic names.
+ */
+ public final Set<String> getOutputTopicNames() {
@big-andy-coates <https://github.com/big-andy-coates> Can you update the
method name according to the KIP discussion?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8483 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5EE3RWTDDTR7SOKZY5G7LROHB6LANCNFSM4MHZUJ2Q>
.
|
Contributor
Author
|
@mjsax updated. |
mjsax
reviewed
May 2, 2020
Member
|
Retest this please |
Contributor
Author
|
Hey @mjsax, sorry for the delay. All changes made. Only outstanding issue is the global table testing, which I'd prefer to defer to someone else. |
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 7, 2020
* 'trunk' of github.com:apache/kafka: (87 commits) KAFKA-9865: Expose output topic names from TopologyTestDriver (apache#8483) MINOR - Increase the number of Trogdor Histogram buckets to 10000 (apache#8627) KAFKA-9768: Fix handling of rest.advertised.listener config (apache#8360) KAFKA-9419: Fix possible integer overflow in CircularIterator (apache#7950) MINOR: Only add 'Data' suffix for generated request/response/header types (apache#8625) KAFKA-9947; Ensure proper shutdown of services in `TransactionsBounceTest` (apache#8602) KAFKA-6342; Remove unused workaround for JSON parsing of non-escaped strings (apache#8591) MINOR: Pass `-release 8` to scalac and upgrade to Gradle 6.4 (apache#8538) KAFKA-9946; Partition deletion event should only be sent if deletion was requested in the StopReplica request (apache#8609) MINOR: Improve TopologyTestDriver JavaDocs (apache#8619) MINOR: MockAdminClient should return InvalidReplicationFactorException if brokers.size < replicationFactor KAFKA-9748: Add Streams eos-beta integration test (apache#8496) KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined (apache#8607) HOTFIX: set correct numIterations in shouldAllowConcurrentAccesses MINOR: Clean up some test dependencies on ConfigCommand and TopicCommand (apache#8527) KAFKA-9918; SslEngineFactory is NOT closed when channel is closing (apache#8551) KAFKA-9798: Send one round synchronously before starting the async producer (apache#8565) MINOR: Annotate KafkaAdminClientTest.testAlterClientQuotas() with @test KAFKA-9589: Enable testLogAppendTimeNonCompressedV2 and fix bug in helper method (apache#8533) MINOR: Use min/max function when possible (apache#8577) ... # Conflicts: # core/src/main/scala/kafka/log/Log.scala # gradle/dependencies.gradle # gradle/wrapper/gradle-wrapper.properties # gradlew
jwijgerd
pushed a commit
to buxapp/kafka
that referenced
this pull request
May 14, 2020
…#8483) Implements KIP-594 Reviewers: Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: https://issues.apache.org/jira/browse/KAFKA-9865
kip: https://cwiki.apache.org/confluence/display/KAFKA/KIP-594%3A+Expose+output+topic+names+from+TopologyTestDriver
This commit exposes the names of the topics the topology produced output to during its run.
Committer Checklist (excluded from commit message)