Docs: expire_snapshots documentation should mention or link to history.expire.max-snapshot-age-ms and history.expire.min-snapshots-to-keep table properties
#3878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y.expire.max-snapshot-age-ms and history.expire.min-snapshots-to-keep table properties
hililiwei
changed the title
history.expire.max-snapshot-age-ms and history.expire.min-snapshots-to-keep table properties
rdblue
reviewed
Jan 17, 2022
site/docs/spark-procedures.md
Outdated
| This procedure will remove old snapshots and data files which are uniquely required by those old snapshots. This means | ||
| the `expire_snapshots` procedure will never remove files which are still required by a non-expired snapshot. | ||
|
|
||
| Available [table behavior properties](./configuration#Table-behavior-properties) for `expire_snapshots`: |
Contributor
There was a problem hiding this comment.
I think that this should be shorter and not duplicate information at the linked location. Otherwise, we need to update it when the defaults change.
This should also be combined with the Usage section below because that contains defaults that are determined by these settings.
Instead of this paragraph, I would add one below the Usage table that states:
If
older_thanandretain_lastare omitted, the table's expiration properties will be used.
…y.expire.max-snapshot-age-ms and history.expire.min-snapshots-to-keep table properties
rdblue
approved these changes
Jan 18, 2022
Contributor
|
Thanks, @hililiwei! |
jackye1995
pushed a commit
to jackye1995/iceberg-docs
that referenced
this pull request
Feb 8, 2022
jackye1995
pushed a commit
to apache/iceberg-docs
that referenced
this pull request
Feb 8, 2022
* apache/iceberg#3723 * apache/iceberg#3732 * apache/iceberg#3749 * apache/iceberg#3766 * apache/iceberg#3787 * apache/iceberg#3796 * apache/iceberg#3809 * apache/iceberg#3820 * apache/iceberg#3878 * apache/iceberg#3890 * apache/iceberg#3892 * apache/iceberg#3944 * apache/iceberg#3976 * apache/iceberg#3993 * apache/iceberg#3996 * apache/iceberg#4008 * apache/iceberg#3758 and 3856 * apache/iceberg#3761 * apache/iceberg#2062 * apache/iceberg#3422 * remove restriction related to legacy parquet file list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y.expire.max-snapshot-age-ms and history.expire.min-snapshots-to-keep table properties
closes #3831