Docs: update spark doc about incremental scan #3796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc: @rdblue |
rdblue
reviewed
Jan 3, 2022
site/docs/spark-queries.md
Outdated
| Currently gets only the data from `append` operation. Cannot support `replace`, `overwrite`, `delete` operations yet. | ||
| Works with both V1 and V2 format-version. | ||
|
|
||
| Incremental read is not yet supported by Spark's SQL syntax. |
Contributor
There was a problem hiding this comment.
Let's remove "yet" because it is unclear whether it will be supported.
rdblue
reviewed
Jan 3, 2022
site/docs/spark-queries.md
Outdated
| ``` | ||
|
|
||
| !!! Note | ||
| Currently gets only the data from `append` operation. Cannot support `replace`, `overwrite`, `delete` operations yet. |
Contributor
There was a problem hiding this comment.
If you want this to be in a note box, it needs to be indented with 4 spaces.
rdblue
reviewed
Jan 3, 2022
site/docs/spark-queries.md
Outdated
|
|
||
| !!! Note | ||
| Currently gets only the data from `append` operation. Cannot support `replace`, `overwrite`, `delete` operations yet. | ||
| Works with both V1 and V2 format-version. |
Contributor
There was a problem hiding this comment.
Is this part of the note or a separate paragraph? Also, could you expand this to be a complete sentence?
rdblue
reviewed
Jan 3, 2022
site/docs/spark-queries.md
Outdated
| * `end-snapshot-id` End snapshot ID used in incremental scans (inclusive) | ||
|
|
||
| ```scala | ||
| // get the data added after start-snapshot-id (10963874102873L) till end-snapshot-id (63874143573109L) |
Contributor
There was a problem hiding this comment.
Typo: "till" should be "until"
rdblue
reviewed
Jan 3, 2022
site/docs/spark-queries.md
Outdated
|
|
||
| ### Incremental read | ||
|
|
||
| To read incremental data between the snapshots, Configure below Spark read options: |
Contributor
There was a problem hiding this comment.
How about "To read appended data incrementally, use:"
rdblue
reviewed
Jan 3, 2022
site/docs/spark-queries.md
Outdated
| To read incremental data between the snapshots, Configure below Spark read options: | ||
|
|
||
| * `start-snapshot-id` Start snapshot ID used in incremental scans (exclusive) | ||
| * `end-snapshot-id` End snapshot ID used in incremental scans (inclusive) |
Contributor
There was a problem hiding this comment.
This is optional. Omitting it will default to the current snapshot.
Member
Author
|
@rdblue : Thanks for the review. I have handled the comments. |
rdblue
approved these changes
Jan 4, 2022
Contributor
|
Thanks, @ajantha-bhat! |
jackye1995
pushed a commit
to jackye1995/iceberg-docs
that referenced
this pull request
Feb 8, 2022
jackye1995
pushed a commit
to apache/iceberg-docs
that referenced
this pull request
Feb 8, 2022
* apache/iceberg#3723 * apache/iceberg#3732 * apache/iceberg#3749 * apache/iceberg#3766 * apache/iceberg#3787 * apache/iceberg#3796 * apache/iceberg#3809 * apache/iceberg#3820 * apache/iceberg#3878 * apache/iceberg#3890 * apache/iceberg#3892 * apache/iceberg#3944 * apache/iceberg#3976 * apache/iceberg#3993 * apache/iceberg#3996 * apache/iceberg#4008 * apache/iceberg#3758 and 3856 * apache/iceberg#3761 * apache/iceberg#2062 * apache/iceberg#3422 * remove restriction related to legacy parquet file list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users in the slack are exploring incremental read in spark and we don't have document for the same. Hence this PR.