Skip to content

Conversation

@hililiwei
Copy link
Contributor

@hililiwei hililiwei commented Dec 17, 2021

close #3746

@github-actions github-actions bot added the docs label Dec 17, 2021
README.md Outdated

| Iceberg version | Spark 2.4.x | Spark 3.0.x | Spark 3.1.x | Spark 3.2.x |
| --------------- | ------------- | -------------- | -------------- | -------------- |
| 0.13.0 | spark-runtime | spark3-runtime | spark3-runtime | spark3-runtime |
Copy link
Member

@ajantha-bhat ajantha-bhat Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.13.0

better to keep 'master branch' for ongoing version and keep all the released version below it.

spark3-runtime

isn't it spark3.0-runtime, 3.1 and 3.2 instead of just spark3 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be iceberg-spark-runtime for 2.4, iceberg-spark3-runtime for 3.0, and then version-specific modules for the rest, iceberg-spark-runtime-3.1_2.12 and iceberg-spark-runtime-3.2_2.12.

@rdblue rdblue changed the title Doc:Update iceberg compatibility description Docs: Update compatibility table Dec 17, 2021
| [DataStream overwrite](#overwrite-data) | ✔️ ️ | |
| [Metadata tables](#inspecting-tables) | | Support Java API but does not support Flink SQL |
| [Rewrite files action](#rewrite-files-action) | ✔️ ️ | |
we only integrate Iceberg with Apache Flink 1.11.x\1.12.x\1.13.x\1.14.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 1.11 supported? I thought that was dropped and only 1.12, 1.13, and 1.14 are supported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hililiwei can you comment on this?

Copy link
Contributor Author

@hililiwei hililiwei Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least in 0.11, we support flink 1.11. During technical selection, our team verified the compatibility. However, the latest version of the code does remove the 1.11 support. I'm not quite sure what the reason for the removal is. .Do we need to ensure the latest version is compatible with 1.11? If so, maybe we need to create a 1.11 module and verify compatibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer #1956

@hililiwei hililiwei requested a review from rdblue December 18, 2021 04:22
README.md Outdated

| Iceberg version | Flink 1.11.x | Flink 1.12.x | Flink 1.13.x | Flink 1.14.x |
| --------------- | --------------------- | --------------------- | --------------------- | --------------------- |
| master branch | iceberg-flink-runtime | iceberg-flink-runtime | iceberg-flink-runtime | iceberg-flink-runtime |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there were similar renames for Flink Jars. Can you take a look and update this table to point to the correct artifacts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.please take a look, thx.

| [DataStream overwrite](#overwrite-data) | ✔️ ️ | |
| [Metadata tables](#inspecting-tables) | | Support Java API but does not support Flink SQL |
| [Rewrite files action](#rewrite-files-action) | ✔️ ️ | |
we only integrate Iceberg with Apache Flink 1.12.x\1.13.x\1.14.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this list. List items in documentation should be separated by , and should use "and" or "or" before the last item.

In addition, please remove personal pronouns, like "we". Documentation should be direct and state what Iceberg does. Using "we" is confusing because it is not clear who it is referred to.

This sentence should be: "Iceberg integration for Apache Flink is available for Flink versions 1.12, 1.13, and 1.14. Previous versions of Iceberg also support Flink 1.11."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update iceberg compatibility description

3 participants