-
Notifications
You must be signed in to change notification settings - Fork 3k
Docs: Update compatibility table #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
|
|
||
| | Iceberg version | Spark 2.4.x | Spark 3.0.x | Spark 3.1.x | Spark 3.2.x | | ||
| | --------------- | ------------- | -------------- | -------------- | -------------- | | ||
| | 0.13.0 | spark-runtime | spark3-runtime | spark3-runtime | spark3-runtime | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.13.0
better to keep 'master branch' for ongoing version and keep all the released version below it.
spark3-runtime
isn't it spark3.0-runtime, 3.1 and 3.2 instead of just spark3 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be iceberg-spark-runtime for 2.4, iceberg-spark3-runtime for 3.0, and then version-specific modules for the rest, iceberg-spark-runtime-3.1_2.12 and iceberg-spark-runtime-3.2_2.12.
site/docs/flink.md
Outdated
| | [DataStream overwrite](#overwrite-data) | ✔️ ️ | | | ||
| | [Metadata tables](#inspecting-tables) | ️ | Support Java API but does not support Flink SQL | | ||
| | [Rewrite files action](#rewrite-files-action) | ✔️ ️ | | | ||
| we only integrate Iceberg with Apache Flink 1.11.x\1.12.x\1.13.x\1.14.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 1.11 supported? I thought that was dropped and only 1.12, 1.13, and 1.14 are supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hililiwei can you comment on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least in 0.11, we support flink 1.11. During technical selection, our team verified the compatibility. However, the latest version of the code does remove the 1.11 support. I'm not quite sure what the reason for the removal is. .Do we need to ensure the latest version is compatible with 1.11? If so, maybe we need to create a 1.11 module and verify compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refer #1956
README.md
Outdated
|
|
||
| | Iceberg version | Flink 1.11.x | Flink 1.12.x | Flink 1.13.x | Flink 1.14.x | | ||
| | --------------- | --------------------- | --------------------- | --------------------- | --------------------- | | ||
| | master branch | iceberg-flink-runtime | iceberg-flink-runtime | iceberg-flink-runtime | iceberg-flink-runtime | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there were similar renames for Flink Jars. Can you take a look and update this table to point to the correct artifacts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.please take a look, thx.
site/docs/flink.md
Outdated
| | [DataStream overwrite](#overwrite-data) | ✔️ ️ | | | ||
| | [Metadata tables](#inspecting-tables) | ️ | Support Java API but does not support Flink SQL | | ||
| | [Rewrite files action](#rewrite-files-action) | ✔️ ️ | | | ||
| we only integrate Iceberg with Apache Flink 1.12.x\1.13.x\1.14.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this list. List items in documentation should be separated by , and should use "and" or "or" before the last item.
In addition, please remove personal pronouns, like "we". Documentation should be direct and state what Iceberg does. Using "we" is confusing because it is not clear who it is referred to.
This sentence should be: "Iceberg integration for Apache Flink is available for Flink versions 1.12, 1.13, and 1.14. Previous versions of Iceberg also support Flink 1.11."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
* apache/iceberg#3723 * apache/iceberg#3732 * apache/iceberg#3749 * apache/iceberg#3766 * apache/iceberg#3787 * apache/iceberg#3796 * apache/iceberg#3809 * apache/iceberg#3820 * apache/iceberg#3878 * apache/iceberg#3890 * apache/iceberg#3892 * apache/iceberg#3944 * apache/iceberg#3976 * apache/iceberg#3993 * apache/iceberg#3996 * apache/iceberg#4008 * apache/iceberg#3758 and 3856 * apache/iceberg#3761 * apache/iceberg#2062 * apache/iceberg#3422 * remove restriction related to legacy parquet file list
close #3746