-
Notifications
You must be signed in to change notification settings - Fork 3k
Revert "Core: Use encoding/decoding methods for namespaces and deprecate Splitter/Joiner" #11574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Core: Use encoding/decoding methods for namespaces and deprecate Splitter/Joiner" #11574
Conversation
…ate Spli…" This reverts commit 5fc1413.
|
I'm not convinced we need to revert this. In my test env I have Trino 465 + 1.7 with nested namespaces enabled, connecting to an Iceberg 1.6 REST catalog. I'm seeing the same error in the REST catalog: |
|
@bryanck the issue is that the 1.7 client sends the query param (where the nested namespace is encoded) using |
|
I retested this and this does resolve the issue (I tested the wrong Trino build previously). |
|
thanks for reviewing and testing this @bryanck |
|
Related issue #11539 |
…ate Spli…" (apache#11574) This reverts commit 5fc1413.
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
…14274) This revisits #10858 (which was reverted in #11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
Reverts #10858
I'll revert this one for now and do a proper fix for 1.8.0