Core: Deprecate Namespace Joiner/Splitter and use separate methods #14274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
encode-decode-namespace-methods
branch
from
3f79b7b to
607f2c5
Compare
singhpk234
reviewed
Oct 7, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, this seems a like a solid first step toward making the seperator configurable.
singhpk234
approved these changes
Oct 7, 2025
nastra
force-pushed
the
encode-decode-namespace-methods
branch
from
607f2c5 to
f59035c
Compare
nastra
force-pushed
the
encode-decode-namespace-methods
branch
from
f59035c to
5689846
Compare
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
nastra
force-pushed
the
encode-decode-namespace-methods
branch
from
5689846 to
9da8ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revisits #10858 (which was reverted in #11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly