-
Notifications
You must be signed in to change notification settings - Fork 3k
Core: Use encoding/decoding methods for namespaces and deprecate Splitter/Joiner #10858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks for the review @Fokko |
|
This change seem to have affected nested namespace support. With encoded params,
before after @nastra please advise if we need to revert this change. |
|
@mayankvadariya can you please open a separate issue for this? Also do you have a reproducible example where this fails? I'm guessing this is in the Trino PR you linked? |
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
…14274) This revisits #10858 (which was reverted in #11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
We want to eventually make the namespace separator configurable. In order to do that, all the encoding / decoding should go through
RestUtil.encodeNamespaceandRestUtil.decodeNamespacerather than using the Splitter / Joiner