Skip to content

Conversation

@nastra
Copy link
Contributor

@nastra nastra commented Aug 2, 2024

We want to eventually make the namespace separator configurable. In order to do that, all the encoding / decoding should go through RestUtil.encodeNamespace and RestUtil.decodeNamespacerather than using the Splitter / Joiner

@nastra nastra requested a review from amogh-jahagirdar August 2, 2024 14:30
@github-actions github-actions bot added the core label Aug 2, 2024
@nastra nastra requested review from Fokko and findepi August 2, 2024 14:52
@nastra
Copy link
Contributor Author

nastra commented Aug 5, 2024

thanks for the review @Fokko

@nastra nastra merged commit 5fc1413 into apache:main Aug 5, 2024
@nastra nastra deleted the use-encode-decode-namespace-methods branch August 5, 2024 12:35
@mayankvadariya
Copy link

This change seem to have affected nested namespace support.

With encoded params, queryParams are further encoded in URIBuilder.

params.forEach(builder::addParameter);

buildUri(path, queryParams) generates following output

before
for queryParams containing parent -> level1�level2
http://localhost:32792/api/catalog/v1/namespaces?parent=level1%1Flevel2&pageToken=

after
for queryParams containing parent -> level1%1Flevel2
http://localhost:32794/api/catalog/v1/namespaces?parent=level1%251Flevel2&pageToken=

@nastra please advise if we need to revert this change.

@nastra
Copy link
Contributor Author

nastra commented Nov 13, 2024

@mayankvadariya can you please open a separate issue for this? Also do you have a reproducible example where this fails? I'm guessing this is in the Trino PR you linked?

@mayankvadariya
Copy link

hi @nastra, I've created #11539 with reproduction steps.

zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
nastra added a commit to nastra/iceberg that referenced this pull request Oct 7, 2025
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f.
We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
nastra added a commit to nastra/iceberg that referenced this pull request Oct 7, 2025
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f.
We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
nastra added a commit to nastra/iceberg that referenced this pull request Oct 8, 2025
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f.
We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
nastra added a commit to nastra/iceberg that referenced this pull request Oct 8, 2025
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f.
We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
nastra added a commit to nastra/iceberg that referenced this pull request Oct 8, 2025
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f.
We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
danielcweeks pushed a commit that referenced this pull request Oct 8, 2025
…14274)

This revisits #10858 (which was reverted in #11574) and uses separate method to join/split a namespace using the unicode character \001f.
We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants