1.7.1 rc0 cherry picks #11589
Closed
1.7.1 rc0 cherry picks #11589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It would be better to be decomposed into three commits. |
Contributor
Author
|
OK I can do that, I was just following this example: #11466 |
Member
|
There are two commits in one PR |
Member
|
+1, I would try to keep the commits separate. 1 Pr but you can cherry pick all the things you like |
Contributor
Author
|
OK, let me try this again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks the following PRs to the 1.7.x branch, in preparation for the 1.7.1 release:
#11516
#11504
#11574