[HUDI-1315] Adding builder for HoodieTableMetaClient initialization

[nsivabalan]

What is the purpose of the pull request

• Adding builder for HoodieTableMetaClient initialization

Brief change log

• Added builder for HoodieTableMetaClient initialization
• Fixed all callers to use builder rather than direct constructors

Verify this pull request

This is a constructor refactoring only. Will rely on travis runs to certify.

Committer checklist

• Has a corresponding JIRA in PR title & commit

• Commit message is descriptive of the change

• CI is green

• Necessary doc changes done or have another open PR

• For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

[codecov-io]

Codecov Report

Merging #2534 (1b857c1) into master (d5f2028) will increase coverage by 18.43%.
The diff coverage is 87.50%.

@@              Coverage Diff              @@
##             master    #2534       +/-   ##
=============================================
+ Coverage     50.92%   69.36%   +18.43%     
+ Complexity     3167      356     -2811     
=============================================
  Files           433       53      -380     
  Lines         19814     1929    -17885     
  Branches       2034      230     -1804     
=============================================
- Hits          10091     1338     -8753     
+ Misses         8903      458     -8445     
+ Partials        820      133      -687     

Flag	Coverage Δ	Complexity Δ
hudicli	?	?
hudiclient	?	?
hudicommon	?	?
hudiflink	?	?
hudihadoopmr	?	?
hudisparkdatasource	?	?
hudisync	?	?
huditimelineservice	?	?
hudiutilities	69.36% <87.50%> (-0.04%)	0.00 <3.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...alCheckpointFromAnotherHoodieTimelineProvider.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...org/apache/hudi/utilities/HoodieClusteringJob.java	65.21% <100.00%> (ø)	9.00 <1.00> (ø)
.../apache/hudi/utilities/HoodieSnapshotExporter.java	88.79% <100.00%> (ø)	28.00 <2.00> (ø)
...apache/hudi/utilities/deltastreamer/DeltaSync.java	70.00% <100.00%> (ø)	50.00 <0.00> (ø)
...i/utilities/deltastreamer/HoodieDeltaStreamer.java	68.72% <100.00%> (-0.26%)	18.00 <0.00> (ø)
...di/utilities/sources/helpers/IncrSourceHelper.java	54.54% <100.00%> (ø)	4.00 <0.00> (ø)
...i-cli/src/main/java/org/apache/hudi/cli/Table.java
.../java/org/apache/hudi/common/util/CommitUtils.java
...a/org/apache/hudi/io/storage/HoodieFileReader.java
...di-cli/src/main/java/org/apache/hudi/cli/Main.java
... and 357 more

[yanghua]

Can we make it more inline? I'd prefer this pattern:

public class HoodieTableMetaClient {
    private HoodieTableMetaClient(xxx) {}

    public static class HoodieTableMetaClientBuilder {}

    public static HoodieTableMetaClientBuilder builder() {
        return new HoodieTableMetaClientBuilder();
    }
}

Usage:

HoodieTableMetaClient.builder().xxx().xxx().build();

wdyt?

[vinothchandar]

also @lw309637554 we were discussing this change on a different PR a while ago

[nsivabalan]

@yanghua : addressed your feedback.

[yanghua]

LGTM.

[yanghua]

@nsivabalan There is a conflicting file.

[nsivabalan]

Fixed it.

[nsivabalan]

@yanghua : feel free to merge this in.

[pengzhiwei2018]

Hi @nsivabalan
This PR support Builder pattern for HoodieMetaClient. But the problem of parameters too long for initTableType method is still exist. I found it is really hard to add a new table property to the initTableType. And I have open another PR to solve this problem at HUDI-1636. Can you please have a look when you have time? thanks.