Skip to content

Conversation

@wangxianghu
Copy link
Contributor

Tips

What is the purpose of the pull request

Introduce FlinkHoodieSimpleIndex to hudi-flink-client

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@wangxianghu wangxianghu marked this pull request as draft November 22, 2020 06:00
@wangxianghu
Copy link
Contributor Author

blocked by #2278

@wangxianghu wangxianghu changed the title [WIP][HUDI-1335] Introduce FlinkHoodieSimpleIndex to hudi-flink-client [HUDI-1335] Introduce FlinkHoodieSimpleIndex to hudi-flink-client Dec 7, 2020
@wangxianghu wangxianghu marked this pull request as ready for review December 7, 2020 09:22
@wangxianghu wangxianghu marked this pull request as draft December 7, 2020 10:13
@wangxianghu wangxianghu force-pushed the HUDI-1335 branch 2 times, most recently from 215b023 to 5d6be46 Compare January 4, 2021 03:15
@wangxianghu wangxianghu marked this pull request as ready for review January 4, 2021 03:17
@wangxianghu
Copy link
Contributor Author

@yanghua please take a look when free

@codecov-io
Copy link

codecov-io commented Jan 4, 2021

Codecov Report

Merging #2271 (da3b6ae) into master (5d053b4) will increase coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2271      +/-   ##
============================================
+ Coverage     49.78%   50.54%   +0.75%     
- Complexity     3089     3119      +30     
============================================
  Files           430      430              
  Lines         19566    19566              
  Branches       2004     2004              
============================================
+ Hits           9741     9889     +148     
+ Misses         9033     8873     -160     
- Partials        792      804      +12     
Flag Coverage Δ Complexity Δ
hudicli 37.21% <ø> (ø) 0.00 <ø> (ø)
hudiclient 100.00% <ø> (ø) 0.00 <ø> (ø)
hudicommon 51.51% <ø> (+0.02%) 0.00 <ø> (ø)
hudiflink 33.03% <ø> (ø) 0.00 <ø> (ø)
hudihadoopmr 33.16% <ø> (ø) 0.00 <ø> (ø)
hudisparkdatasource 69.51% <ø> (ø) 0.00 <ø> (ø)
hudisync 48.61% <ø> (ø) 0.00 <ø> (ø)
huditimelineservice 66.49% <ø> (ø) 0.00 <ø> (ø)
hudiutilities 69.43% <ø> (+7.56%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/hudi/utilities/UtilHelpers.java 64.16% <0.00%> (+1.15%) 33.00% <0.00%> (+1.00%)
...i/utilities/deltastreamer/HoodieDeltaStreamer.java 68.97% <0.00%> (+1.22%) 18.00% <0.00%> (+1.00%)
...e/hudi/common/table/log/HoodieLogFormatWriter.java 79.68% <0.00%> (+1.56%) 26.00% <0.00%> (ø%)
...ties/deltastreamer/HoodieDeltaStreamerMetrics.java 36.11% <0.00%> (+2.77%) 6.00% <0.00%> (+1.00%)
...utilities/deltastreamer/TableExecutionContext.java 65.00% <0.00%> (+65.00%) 9.00% <0.00%> (+9.00%)
...s/deltastreamer/HoodieMultiTableDeltaStreamer.java 78.39% <0.00%> (+78.39%) 18.00% <0.00%> (+18.00%)

Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanghua
Copy link
Contributor

yanghua commented Jan 30, 2021

@wangxianghu Please fix the conflicting file.

@yanghua yanghua merged commit d74d8e2 into apache:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants