Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stackoverflow in SerializeSecurityConfigurator #11561

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Fix #11560

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ changed the base branch from 3.2 to 3.1 February 15, 2023 05:36
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11561 (eebcc05) into 3.1 (1ab11d3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.1   #11561      +/-   ##
============================================
- Coverage     64.64%   64.64%   -0.01%     
  Complexity       14       14              
============================================
  Files          1431     1431              
  Lines         59975    60017      +42     
  Branches       8808     8816       +8     
============================================
+ Hits          38770    38796      +26     
- Misses        17133    17144      +11     
- Partials       4072     4077       +5     
Impacted Files Coverage Δ
...bo/common/utils/SerializeSecurityConfigurator.java 94.96% <100.00%> (+0.09%) ⬆️
.../serialize/hessian2/Hessian2SerializerFactory.java 50.00% <0.00%> (-50.00%) ⬇️
...gistrycenter/processor/ZookeeperUnixProcessor.java 60.71% <0.00%> (-17.86%) ⬇️
...g/apache/dubbo/remoting/api/ConnectionHandler.java 51.51% <0.00%> (-9.10%) ⬇️
...bbo/rpc/cluster/support/ForkingClusterInvoker.java 83.33% <0.00%> (-4.77%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0.00%> (-4.35%) ⬇️
...ache/dubbo/common/extension/ExtensionDirector.java 93.33% <0.00%> (-3.34%) ⬇️
...on/serialize/fastjson2/FastJson2Serialization.java 9.52% <0.00%> (-2.25%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 80.95% <0.00%> (-1.20%) ⬇️
...bbo/common/utils/DefaultSerializeClassChecker.java 90.80% <0.00%> (-1.06%) ⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 6d28a1a into apache:3.1 Feb 15, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 16, 2023
* mytang0/3.2: (33 commits)
  Fix conflict
  Update codecov config (apache#11580)
  Set timeout value to string (apache#11565)
  Skip mapping retry if metadata config is invalid (apache#11323)
  Fix stackoverflow in SerializeSecurityConfigurator (apache#11561)
  Revert clear response operation of timeoutfilter (apache#11562)
  Fix hessian2 serializable check (apache#11573)
  feat: fix oom (apache#11571)
  Enhance service discovery update interval (apache#11223)
  Metrics code opt: redundant, modifier, magic (apache#11553)
  Perfect some code (apache#11533)
  feat: dubbo provided by (apache#11390)
  Enhance serializable check option (apache#11460)
  Fix config absent when refresh (apache#11505)
  Enhance json util check (apache#11501)
  Fix the bug in LFUCache#put() method (apache#11538)
  Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547)
  Bump consul-api from 1.4.2 to 1.4.5 (apache#11545)
  Bump maven-core from 3.8.7 to 3.9.0 (apache#11546)
  Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548)
  ...

# Conflicts:
#	dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 20, 2023
* origin/3.2: (22 commits)
  Update codecov config (apache#11582)
  metric package structure optimization (apache#11576)
  Fix compile
  Provides the public part of metrics data collection and export (apache#11522)
  [Triple] Fix boxed type methods (apache#11577)
  Bump to 3.2.0-beta.6-SNAPSHOT
  Fix synchronized in ModelEnvironment (apache#11584)
  Fix conflict
  Fix concurrent issue in scope model (apache#11525)
  Update codecov config (apache#11580)
  Set timeout value to string (apache#11565)
  Skip mapping retry if metadata config is invalid (apache#11323)
  Fix stackoverflow in SerializeSecurityConfigurator (apache#11561)
  Revert clear response operation of timeoutfilter (apache#11562)
  Fix hessian2 serializable check (apache#11573)
  feat: fix oom (apache#11571)
  Enhance serializable check option (apache#11460)
  Fix config absent when refresh (apache#11505)
  Enhance json util check (apache#11501)
  classNotFound (apache#11552)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackOverflowError occurred in SerializeSecurityConfigurator
2 participants