Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip mapping retry if metadata config is invalid #11323

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #11323 (f6b9984) into 3.1 (59a62a6) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head f6b9984 differs from pull request most recent head 42eea33. Consider uploading reports for the commit 42eea33 to get more accurate results

@@             Coverage Diff              @@
##                3.1   #11323      +/-   ##
============================================
- Coverage     64.66%   64.64%   -0.03%     
  Complexity       14       14              
============================================
  Files          1431     1431              
  Lines         60014    60015       +1     
  Branches       8815     8815              
============================================
- Hits          38807    38795      -12     
- Misses        17131    17145      +14     
+ Partials       4076     4075       -1     
Impacted Files Coverage Δ
.../org/apache/dubbo/metadata/ServiceNameMapping.java 86.66% <ø> (ø)
...ry/client/metadata/MetadataServiceNameMapping.java 85.91% <0.00%> (-1.23%) ⬇️
...in/java/org/apache/dubbo/config/ServiceConfig.java 70.50% <100.00%> (-0.24%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 51.13% <0.00%> (-7.96%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-4.35%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.64% <0.00%> (-3.23%) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 62.58% <0.00%> (-3.15%) ⬇️
...adata/store/zookeeper/ZookeeperMetadataReport.java 71.27% <0.00%> (-1.07%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 76.22% <0.00%> (-0.82%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit d874a87 into apache:3.1 Feb 15, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 16, 2023
* mytang0/3.2: (33 commits)
  Fix conflict
  Update codecov config (apache#11580)
  Set timeout value to string (apache#11565)
  Skip mapping retry if metadata config is invalid (apache#11323)
  Fix stackoverflow in SerializeSecurityConfigurator (apache#11561)
  Revert clear response operation of timeoutfilter (apache#11562)
  Fix hessian2 serializable check (apache#11573)
  feat: fix oom (apache#11571)
  Enhance service discovery update interval (apache#11223)
  Metrics code opt: redundant, modifier, magic (apache#11553)
  Perfect some code (apache#11533)
  feat: dubbo provided by (apache#11390)
  Enhance serializable check option (apache#11460)
  Fix config absent when refresh (apache#11505)
  Enhance json util check (apache#11501)
  Fix the bug in LFUCache#put() method (apache#11538)
  Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547)
  Bump consul-api from 1.4.2 to 1.4.5 (apache#11545)
  Bump maven-core from 3.8.7 to 3.9.0 (apache#11546)
  Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548)
  ...

# Conflicts:
#	dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 20, 2023
* origin/3.2: (22 commits)
  Update codecov config (apache#11582)
  metric package structure optimization (apache#11576)
  Fix compile
  Provides the public part of metrics data collection and export (apache#11522)
  [Triple] Fix boxed type methods (apache#11577)
  Bump to 3.2.0-beta.6-SNAPSHOT
  Fix synchronized in ModelEnvironment (apache#11584)
  Fix conflict
  Fix concurrent issue in scope model (apache#11525)
  Update codecov config (apache#11580)
  Set timeout value to string (apache#11565)
  Skip mapping retry if metadata config is invalid (apache#11323)
  Fix stackoverflow in SerializeSecurityConfigurator (apache#11561)
  Revert clear response operation of timeoutfilter (apache#11562)
  Fix hessian2 serializable check (apache#11573)
  feat: fix oom (apache#11571)
  Enhance serializable check option (apache#11460)
  Fix config absent when refresh (apache#11505)
  Enhance json util check (apache#11501)
  classNotFound (apache#11552)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants