feat: dubbo provided by #11390

aamingaa · 2023-01-28T15:42:19Z

related to #10374

AlbumenJ · 2023-01-30T03:35:05Z

dubbo-common/src/main/java/org/apache/dubbo/config/annotation/DubboProvidedbBy.java

+@Retention(RetentionPolicy.RUNTIME)
+@Target({ElementType.TYPE})
+@Inherited
+public @interface DubboProvidedbBy {


Suggested change

public @interface DubboProvidedbBy {

public @interface ProvidedbBy {

codecov-commenter · 2023-02-05T04:42:15Z

Codecov Report

Merging #11390 (5348580) into 3.2 (33d4288) will decrease coverage by 2.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11390      +/-   ##
============================================
- Coverage     69.57%   67.34%   -2.24%     
+ Complexity      133        2     -131     
============================================
  Files          1515     1508       -7     
  Lines         82438    62673   -19765     
  Branches      14756     9187    -5569     
============================================
- Hits          57359    42209   -15150     
+ Misses        20240    16317    -3923     
+ Partials       4839     4147     -692

Impacted Files	Coverage Δ
.../config/spring/reference/ReferenceBeanSupport.java
...ache/dubbo/rpc/protocol/AbstractProxyProtocol.java
...e/dubbo/reactive/ClientTripleReactorPublisher.java
...java/org/apache/dubbo/rpc/model/ConsumerModel.java
...est/AbstractAnnotatedMethodParameterProcessor.java
...nnotation/AbstractAnnotationBeanPostProcessor.java
...e/dubbo/remoting/transport/netty/NettyHandler.java
...ain/java/org/apache/dubbo/common/URLStrParser.java
...bo/rpc/cluster/router/tag/model/TagRuleParser.java
...o/registry/zookeeper/ZookeeperRegistryFactory.java
... and 3013 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AlbumenJ · 2023-02-06T11:59:26Z

dubbo-common/src/main/java/org/apache/dubbo/config/annotation/ProvidedbBy.java

+@Retention(RetentionPolicy.RUNTIME)
+@Target({ElementType.TYPE})
+@Inherited
+public @interface ProvidedbBy {


Suggested change

public @interface ProvidedbBy {

public @interface ProvidedBy {

AlbumenJ · 2023-02-06T11:59:50Z

dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java

@@ -518,9 +518,8 @@ private boolean checkMeshConfig(Map<String, String> referenceParameters) {

        String providedBy = referenceParameters.get(PROVIDED_BY);
        if (StringUtils.isEmpty(providedBy)) {
-            throw new IllegalStateException("In mesh mode, the providedBy of ReferenceConfig is must be set");
+            throw new IllegalStateException("In mesh mode, the providedBy or dubboProvidedBy of ReferenceConfig is must be set");


Suggested change

throw new IllegalStateException("In mesh mode, the providedBy or dubboProvidedBy of ReferenceConfig is must be set");

throw new IllegalStateException("In mesh mode, the providedBy of ReferenceConfig is must be set");

AlbumenJ · 2023-02-06T12:00:03Z

...onfig-spring/src/main/java/org/apache/dubbo/config/spring/reference/ReferenceAttributes.java

@@ -51,7 +51,6 @@ public interface ReferenceAttributes {
    String PARAMETERS = "parameters";

    String PROVIDED_BY = "providedBy";
-


…aa/dubbo into feature/dubbo_provided_by

AlbumenJ · 2023-02-07T08:08:09Z

...nfig-spring/src/main/java/org/apache/dubbo/config/spring/reference/ReferenceBeanSupport.java

@@ -78,6 +79,17 @@ public static void convertReferenceProps(Map<String, Object> attributes, Class d
            interfaceName = defaultInterfaceClass.getName();
        }
        Assert.notEmptyString(interfaceName, "The interface class or name of reference was not found");
+        Class<?> clazz = ClassUtils.resolveClass(interfaceName, defaultInterfaceClass.getClassLoader());


Suggested change

Class<?> clazz = ClassUtils.resolveClass(interfaceName, defaultInterfaceClass.getClassLoader());

Class<?> clazz = getInterfaceClass();

AlbumenJ · 2023-02-09T04:23:10Z

dubbo-common/src/main/java/org/apache/dubbo/config/annotation/ProvidedBy.java

+
+/**
+ * Class-level annotation used for declaring Dubbo interface.
+ * @DubboProvidedbBy("dubbo-samples-xds-provider")


Suggested change

* @DubboProvidedbBy("dubbo-samples-xds-provider")

* @ProvidedBy("dubbo-samples-xds-provider")

AlbumenJ

LGTM

sonarcloud · 2023-02-14T08:29:51Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

89.3% Coverage
0.0% Duplication

AlbumenJ

LGTM

AlbumenJ · 2023-02-14T22:52:43Z

Please submit some related docs to dubbo-website

* mytang0/3.2: Enhance service discovery update interval (apache#11223) Metrics code opt: redundant, modifier, magic (apache#11553) Perfect some code (apache#11533) feat: dubbo provided by (apache#11390)

* mytang0/3.2: (33 commits) Fix conflict Update codecov config (apache#11580) Set timeout value to string (apache#11565) Skip mapping retry if metadata config is invalid (apache#11323) Fix stackoverflow in SerializeSecurityConfigurator (apache#11561) Revert clear response operation of timeoutfilter (apache#11562) Fix hessian2 serializable check (apache#11573) feat: fix oom (apache#11571) Enhance service discovery update interval (apache#11223) Metrics code opt: redundant, modifier, magic (apache#11553) Perfect some code (apache#11533) feat: dubbo provided by (apache#11390) Enhance serializable check option (apache#11460) Fix config absent when refresh (apache#11505) Enhance json util check (apache#11501) Fix the bug in LFUCache#put() method (apache#11538) Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547) Bump consul-api from 1.4.2 to 1.4.5 (apache#11545) Bump maven-core from 3.8.7 to 3.9.0 (apache#11546) Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548) ... # Conflicts: # dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java

aamingaa added 2 commits January 28, 2023 23:41

feat: dubbo provided by

4d689cf

feat: dubbo provided by

4e71be2

aamingaa mentioned this pull request Jan 29, 2023

dubbo 使用 k8s 为注册中心，消费者@DubboReference providedby 不配置提示没有服务提供者 #10374

Closed

AlbumenJ requested changes Jan 30, 2023

View reviewed changes

aamingaa added 6 commits February 4, 2023 19:06

feat: remove dubbo provided by

ce858dd

feat: add multi provided by

5da4e4f

feat: add multi provided by

c135729

feat: add unit test

33de641

feat: add unit test

3aee5f8

feat: add claszz judge

355bccc

aamingaa added 3 commits February 5, 2023 15:18

Update LoggerCodeConstants.java

545df67

Update AbstractReferenceConfig.java

db81b24

Update ServiceNameMapping.java

ddf100f

AlbumenJ requested changes Feb 6, 2023

View reviewed changes

aamingaa added 3 commits February 6, 2023 20:05

feat: add provided by

4c2bdc7

Merge branch 'feature/dubbo_provided_by' of https://github.com/aaming…

c763aa2

…aa/dubbo into feature/dubbo_provided_by

feat: beauty the pr

4fbb500

AlbumenJ requested changes Feb 7, 2023

View reviewed changes

feat: modify defaultInterfaceClass

b7066ef

AlbumenJ requested changes Feb 9, 2023

View reviewed changes

aamingaa added 3 commits February 9, 2023 23:11

feat: merge two type provided by

8f6a20b

feat: remove class

3e1738f

feat: remove unuse code

a7021a5

AlbumenJ approved these changes Feb 10, 2023

View reviewed changes

feat: fix commit debug

80295e6

aamingaa requested a review from AlbumenJ February 13, 2023 11:00

feat: modify if judge

5348580

AlbumenJ approved these changes Feb 14, 2023

View reviewed changes

AlbumenJ merged commit 2b945f8 into apache:3.2 Feb 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: dubbo provided by #11390

feat: dubbo provided by #11390

aamingaa commented Jan 28, 2023

AlbumenJ Jan 30, 2023

codecov-commenter commented Feb 5, 2023 •

edited

Loading

AlbumenJ Feb 6, 2023

AlbumenJ Feb 6, 2023

AlbumenJ Feb 6, 2023

AlbumenJ Feb 7, 2023

AlbumenJ Feb 9, 2023

AlbumenJ left a comment

sonarcloud bot commented Feb 14, 2023

AlbumenJ left a comment

AlbumenJ commented Feb 14, 2023

	public @interface DubboProvidedbBy {
	public @interface ProvidedbBy {

	public @interface ProvidedbBy {
	public @interface ProvidedBy {

	throw new IllegalStateException("In mesh mode, the providedBy or dubboProvidedBy of ReferenceConfig is must be set");
	throw new IllegalStateException("In mesh mode, the providedBy of ReferenceConfig is must be set");

		@@ -51,7 +51,6 @@ public interface ReferenceAttributes {
		String PARAMETERS = "parameters";

		String PROVIDED_BY = "providedBy";

	Class<?> clazz = ClassUtils.resolveClass(interfaceName, defaultInterfaceClass.getClassLoader());
	Class<?> clazz = getInterfaceClass();

	* @DubboProvidedbBy("dubbo-samples-xds-provider")
	* @ProvidedBy("dubbo-samples-xds-provider")

feat: dubbo provided by #11390

feat: dubbo provided by #11390

Conversation

aamingaa commented Jan 28, 2023

AlbumenJ Jan 30, 2023

Choose a reason for hiding this comment

codecov-commenter commented Feb 5, 2023 • edited Loading

Codecov Report

AlbumenJ Feb 6, 2023

Choose a reason for hiding this comment

AlbumenJ Feb 6, 2023

Choose a reason for hiding this comment

AlbumenJ Feb 6, 2023

Choose a reason for hiding this comment

AlbumenJ Feb 7, 2023

Choose a reason for hiding this comment

AlbumenJ Feb 9, 2023

Choose a reason for hiding this comment

AlbumenJ left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Feb 14, 2023

AlbumenJ left a comment

Choose a reason for hiding this comment

AlbumenJ commented Feb 14, 2023

codecov-commenter commented Feb 5, 2023 •

edited

Loading