Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric package structure optimization #11576

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented Feb 15, 2023

When burying points in the registration center, you need to use metrics-api, but there is an extension of clusterFilter in metrics-api, which will cause circular dependency problems. Move the metrics-api related filter to the default package to solve.

@codecov-commenter
Copy link

Codecov Report

Merging #11576 (b8fe753) into 3.2 (551ff4a) will decrease coverage by 1.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11576      +/-   ##
============================================
- Coverage     68.70%   67.35%   -1.35%     
+ Complexity      341        2     -339     
============================================
  Files          3073     1508    -1565     
  Lines        146713    62688   -84025     
  Branches      24445     9189   -15256     
============================================
- Hits         100799    42224   -58575     
+ Misses        36866    16302   -20564     
+ Partials       9048     4162    -4886     
Impacted Files Coverage Δ
...e/dubbo/remoting/transport/netty/NettyChannel.java 47.72% <0.00%> (-9.10%) ⬇️
...ting/exchange/support/header/HeartbeatHandler.java 59.52% <0.00%> (-7.15%) ⬇️
...oting/transport/netty4/NettyConnectionHandler.java 53.19% <0.00%> (-6.39%) ⬇️
...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java 72.35% <0.00%> (-4.88%) ⬇️
...bbo/rpc/cluster/support/ForkingClusterInvoker.java 80.95% <0.00%> (-4.77%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0.00%> (-4.35%) ⬇️
...mon/serialize/hessian2/Hessian2FactoryManager.java 38.77% <0.00%> (-4.09%) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 60.52% <0.00%> (-3.95%) ⬇️
.../registry/zookeeper/ZookeeperServiceDiscovery.java 70.51% <0.00%> (-3.85%) ⬇️
...moting/transport/netty4/NettyConnectionClient.java 75.48% <0.00%> (-2.59%) ⬇️
... and 1591 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mytang0 mytang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

54.5% 54.5% Coverage
7.0% 7.0% Duplication

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 186fd5c into apache:3.2 Feb 16, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 20, 2023
* origin/3.2: (22 commits)
  Update codecov config (apache#11582)
  metric package structure optimization (apache#11576)
  Fix compile
  Provides the public part of metrics data collection and export (apache#11522)
  [Triple] Fix boxed type methods (apache#11577)
  Bump to 3.2.0-beta.6-SNAPSHOT
  Fix synchronized in ModelEnvironment (apache#11584)
  Fix conflict
  Fix concurrent issue in scope model (apache#11525)
  Update codecov config (apache#11580)
  Set timeout value to string (apache#11565)
  Skip mapping retry if metadata config is invalid (apache#11323)
  Fix stackoverflow in SerializeSecurityConfigurator (apache#11561)
  Revert clear response operation of timeoutfilter (apache#11562)
  Fix hessian2 serializable check (apache#11573)
  feat: fix oom (apache#11571)
  Enhance serializable check option (apache#11460)
  Fix config absent when refresh (apache#11505)
  Enhance json util check (apache#11501)
  classNotFound (apache#11552)
  ...
@wxbty wxbty deleted the observation branch February 25, 2023 11:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants