Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy CI failures on main after Rust 1.80 release #11651

Closed
alamb opened this issue Jul 25, 2024 · 2 comments · Fixed by #11654
Closed

Clippy CI failures on main after Rust 1.80 release #11651

alamb opened this issue Jul 25, 2024 · 2 comments · Fixed by #11654
Labels
bug Something isn't working development-process Related to development process of DataFusion

Comments

@alamb
Copy link
Contributor

alamb commented Jul 25, 2024

Describe the bug

Clippy started failing in main. For example

Given that a new rust version was just released today I suspect it is that clippy has gotten more stringent
https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-180-2024-07-25

To Reproduce

No response

Expected behavior

CI should be passing

Additional context

I believe @nrc has fixed some of these already in #11467, but we got stuck there on tests that only failed once we properly passed through hash_collisions

@findepi
Copy link
Member

findepi commented Jul 25, 2024

To prevent all PR builds from failing we can maybe restore the previous Clippy version?
At least this is what I am trying in #11655.

#11467 fixes some of the problems (notably force_hash_collisions related)
I found some other formatting issues that new clippy complains about: #11654

@findepi
Copy link
Member

findepi commented Jul 25, 2024

#11655 fixed CI by downgrading Clippy
#11657 covers the errors and re-upgrading Clippy.

should we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants