Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window function test fails when force_hash_collisions is enabled #11660

Closed
alamb opened this issue Jul 25, 2024 · 0 comments · Fixed by #11939
Closed

Window function test fails when force_hash_collisions is enabled #11660

alamb opened this issue Jul 25, 2024 · 0 comments · Fixed by #11939
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Jul 25, 2024

Describe the bug

The force_hash_collisions feature flag is intended to ensure DataFusion works correctly even in the very unlikely event that hash values collide.

The new version of clippy in Rust 1.80 found we had not been running some tests with this flag #11651

And it turns out when we started running the tests with the hash collision they failed

we commented them out in #11654 but we should really figure out why they failed

Maybe the test needs to be updated or maybe there is a real bug

cargo test --test sqllogictests --features=force_hash_collisions -- parquet

To Reproduce

Uncomment the tests in parquet.slt that was commented out in #11654 and then run

cargo test --test sqllogictests --features=force_hash_collisions -- parquet

Expected behavior

Tests should pass

Additional context

No response

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant