Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily pin toolchain version to avoid clippy errors #11655

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Temporarily pin toolchain version to avoid clippy errors #11655

merged 1 commit into from
Jul 25, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Jul 25, 2024 •
edited by alamb
Loading

Temporarily pin toolchain version until we solve problems reported by newer clippy release.

Closes for #11651

@findepi
Temporarily pin toolchain version to avoid clippy
f44836f 
Temporarily pin toolchain version until we solve problems reported by
newer clippy release.
@findepi findepi force-pushed the findepi/temporarily-pin-toolchain-version-to-avoid-clippy-fde0e5 branch from 8c4c5c4 to f44836f Compare July 25, 2024 18:52
@findepi findepi mentioned this pull request Jul 25, 2024
Closed
@findepi
Copy link
Member Author

findepi commented Jul 25, 2024

@alamb @jayzhan211 @comphead
this may be merge-able as a stop-gap. please review

(and #11654 may become a full fix)

@alamb alamb mentioned this pull request Jul 25, 2024
Closed
alamb
alamb approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you (very much) @findepi

I filed #11657 to track removing this stop gap measure and updated this PR to close the ticket (as it fixes the issue reported on the issue)

@alamb alamb changed the title Temporarily pin toolchain version to avoid clippy Temporarily pin toolchain version to avoid clippy errors Jul 25, 2024
@alamb
Copy link
Contributor

alamb commented Jul 25, 2024

Merging this in to get main green again

@alamb alamb merged commit 5b7e0aa into apache:main Jul 25, 2024
26 checks passed
@alamb
Copy link
Contributor

alamb commented Jul 25, 2024 •
edited
Loading

Thanks again @findepi

@findepi findepi deleted the findepi/temporarily-pin-toolchain-version-to-avoid-clippy-fde0e5 branch July 25, 2024 19:48
alamb added a commit to alamb/datafusion that referenced this pull request Jul 25, 2024
@alamb
Revert "Temporarily pin toolchain version to avoid clippy (apache#11655…
8bd8aeb 
…)"

This reverts commit 5b7e0aa.
@alamb alamb mentioned this pull request Jul 25, 2024
Merged
comphead pushed a commit that referenced this pull request Jul 26, 2024
@alamb
Run CI with latest (Rust 1.80), add ticket references to commented ou…
01dc3f9 
…t tests (#11661)

* Revert "Temporarily pin toolchain version to avoid clippy (#11655)"

This reverts commit 5b7e0aa.

* Add ticket references in comments
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findepi @alamb