Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join_inner_two, join_inner_one_two_parts_left and join_inner_one_two_parts_right fail with force_hash_collisions #11658

Closed
alamb opened this issue Jul 25, 2024 · 2 comments · Fixed by #11806
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@alamb
Copy link
Contributor

alamb commented Jul 25, 2024

Describe the bug

The force_hash_collisions feature flag is intended to ensure DataFusion works correctly even in the very unlikely event that hash values collide.

The new version of clippy in Rust 1.80 found we had not been running some tests with this flag #11651

And it turns out when we started running the tests with the hash collision they failed

we commented them out in #11654 but we should really figure out why they failed

Maybe the test needs to be updated or maybe there is a real bug

To Reproduce

Remove these lines from the tests mentioned above

    #[cfg(not(feature = "force_hash_collisions"))]

Then run

cargo test -p datafusion-physical-plan --features=force_hash_collisions

Expected behavior

Tests should pass

Additional context

No response

@Kev1n8
Copy link
Contributor

Kev1n8 commented Jul 29, 2024

take

@Kev1n8
Copy link
Contributor

Kev1n8 commented Aug 1, 2024

Here is some info I found for anyone who wants to dig into it. I hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
2 participants