Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Clippy clean for Rust 1.80 and run it on CI #11657

Closed
alamb opened this issue Jul 25, 2024 · 5 comments · Fixed by #11661
Closed

Get Clippy clean for Rust 1.80 and run it on CI #11657

alamb opened this issue Jul 25, 2024 · 5 comments · Fixed by #11661
Labels
development-process Related to development process of DataFusion enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jul 25, 2024

Is your feature request related to a problem or challenge?

A new Rust version was released that causes CI to fail -- see #11651

@findepi made a PR to pin CI to use Rust 1.79 while we work out the clippy failures: #11655

We should remove the wokaround and use the latest rust once we have sorted out clippy

Describe the solution you'd like

Remove the workaround file and use the latest rust again

Describe alternatives you've considered

No response

Additional context

No response

@alamb
Copy link
Contributor Author

alamb commented Jul 25, 2024

Note I believe @nrc has fixed some of these already in #11467, but we got stuck there on tests that only failed once we properly passed through hash_collisions

@alamb alamb added the help wanted Extra attention is needed label Jul 25, 2024
@findepi
Copy link
Member

findepi commented Jul 25, 2024

#11654 includes #11467 and passes clippy 1.80 locally

but we got stuck there on tests that only failed once we properly passed through hash_collisions

outstanding action item

@alamb
Copy link
Contributor Author

alamb commented Jul 25, 2024

I am filing some tickets to track the new test failures

@alamb
Copy link
Contributor Author

alamb commented Jul 25, 2024

I will handle this item (now that #11654 is merged)

@alamb alamb added development-process Related to development process of DataFusion and removed help wanted Extra attention is needed labels Jul 25, 2024
@alamb
Copy link
Contributor Author

alamb commented Jul 25, 2024

#11661 is up

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants