SIMD-0185: vote-program: add vote state v4 feature gate#8290
Merged
buffalojoec merged 3 commits intoanza-xyz:masterfrom Oct 17, 2025
Merged
SIMD-0185: vote-program: add vote state v4 feature gate#8290buffalojoec merged 3 commits intoanza-xyz:masterfrom
buffalojoec merged 3 commits intoanza-xyz:masterfrom
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
buffalojoec
force-pushed
the
vote-state-v4-feature-gate
branch
from
f5f336a to
f688365
Compare
buffalojoec
force-pushed
the
vote-state-v4-feature-gate
branch
from
f688365 to
f95e471
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8290 +/- ##
========================================
Coverage 83.1% 83.1%
========================================
Files 849 849
Lines 368644 368877 +233
========================================
+ Hits 306667 306870 +203
- Misses 61977 62007 +30 🚀 New features to boost your workflow:
|
Author
|
Shifting to a draft until:
|
|
Can we add the SIMD number in the PR title for this? |
buffalojoec
changed the title
buffalojoec
force-pushed
the
vote-state-v4-feature-gate
branch
from
f95e471 to
95304dc
Compare
jstarry
approved these changes
Oct 17, 2025
rustopian
pushed a commit
to rustopian/agave
that referenced
this pull request
Nov 20, 2025
* vote-program: refactor tests to use `vote_state_v4_enabled` switch * vote-program: add vote state v4 feature gate * runtime: add stake program vote state v4 upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #8191, the Vote program has the necessary plumbing to support a "switch" over to vote state v4 based on a feature gate. That feature gate has not been added yet, but it's time to add it.
With the new feature gate, the program effectively becomes dynamic over the v4 feature gate, continuing to convert vote accounts to v3 as before, but able to switch to v4 as the target version when the feature is activated.
Note there are a number of areas around the codebase that either depend on or test with vote state. As such, many of these areas require refactoring to support/test vote state v4 integration.
Summary of Changes
Completes the implementation of
VoteStateV4in the Vote program by first refactoring the remaining tests invote_processor, then adding the new feature gate that will toggle on support for vote state v4.