program: deserialize v3 and v4 vote state#89
Closed
buffalojoec wants to merge 2 commits intobump-deps-sdk-3.0from
Closed
program: deserialize v3 and v4 vote state#89buffalojoec wants to merge 2 commits intobump-deps-sdk-3.0from
buffalojoec wants to merge 2 commits intobump-deps-sdk-3.0from
Conversation
buffalojoec
force-pushed
the
vote-state-v4-deser
branch
from
22bc5c9 to
810990f
Compare
buffalojoec
force-pushed
the
bump-deps-sdk-3.0
branch
from
1c20b13 to
fd6ad28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Stake program to support deserializing - with the optimized approach - either vote state v3 or v4. Also does a little refactoring in the tests so I could add
test_caseto test all vote-state-related tests against both v3 and v4.Depends on #88.
@jstarry We're in a bit of a pickle here.
It's a ton easier if we use the updated
solana-vote-programcrate, which has the generic processor andVoteStateHandle. Otherwise, we'd have to reimplement things likeprocess_vote_unchecked. I've linked it viagitfor now, but it depends on anza-xyz/agave#8312. However, in order to do that, we'd need to backport all of the handler logic to 3.0.Additionally, this change has to go in, and we have to add the newly compiled program ELF to the monorepo, like I've done under a "TEMP" commit in anza-xyz/agave#8290.