vote-program: keep block revenue collector in sync with node pubkey#8506
Merged
buffalojoec merged 2 commits intoanza-xyz:masterfrom Oct 16, 2025
Merged
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
buffalojoec
commented
Oct 16, 2025
Comment on lines
+358
to
+361
| fn set_block_revenue_collector(&mut self, _collector: Pubkey) { | ||
| // No-op for v3: field does not exist. | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
I know this looks weird, but I intentionally didn't tuck the syncing into VoteStateV4::set_node_pubkey because:
- We will clean up
impl VoteStateHandle for VoteStateV3once the feature is active and the target version is always v4 - We will need to decouple the setting of block revenue collector anyway
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8506 +/- ##
=======================================
Coverage 83.1% 83.1%
=======================================
Files 848 848
Lines 368475 368558 +83
=======================================
+ Hits 306495 306590 +95
+ Misses 61980 61968 -12 🚀 New features to boost your workflow:
|
jstarry
approved these changes
Oct 16, 2025
rustopian
pushed a commit
to rustopian/agave
that referenced
this pull request
Nov 20, 2025
…nza-xyz#8506) * vote-program: keep block revenue collector in sync with node pubkey * add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As per the amendment to SIMD-0185 in solana-foundation/solana-improvement-documents#369, we need to make sure the block revenue collector (a v4-only field) is kept in sync with the node pubkey.
Summary of Changes
In the processor for
UpdateValidatorIdentity, add a step to also update the block revenue collector.