clean up remaining vote state v4 TODOs#8540
Merged
buffalojoec merged 3 commits intoanza-xyz:masterfrom Oct 20, 2025
Merged
Conversation
buffalojoec
changed the title
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @buffalojoec. |
jstarry
reviewed
Oct 18, 2025
| assert_eq!(&vote_state.node_pubkey, vote_state_view.node_pubkey()); | ||
| assert_eq!(vote_state.commission, vote_state_view.commission()); | ||
| assert_eq!(vote_state.credits(), vote_state_view.credits()); | ||
| assert_eq!(vote_state.inflation_rewards_commission_bps, vote_state_view.commission().into()); |
There was a problem hiding this comment.
You're comparing basis points with percentage here, need to pick one or the other
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8540 +/- ##
=========================================
- Coverage 83.1% 83.1% -0.1%
=========================================
Files 847 847
Lines 368648 368651 +3
=========================================
- Hits 306675 306515 -160
- Misses 61973 62136 +163 🚀 New features to boost your workflow:
|
jstarry
approved these changes
Oct 20, 2025
rustopian
pushed a commit
to rustopian/agave
that referenced
this pull request
Nov 20, 2025
* vote-state-v4: clean up remaining TODOs * vote: update tests/benches * review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As the title says, we left a few TODOs lying around from #8384 that can finally be addressed now that #8290 has landed.
Summary of Changes
Fix those TODOs by converting their callsites to
VoteStateV4.