Add clippy rule to deny uninlined-format-args#7826
Conversation
|
As expected, some CI failures with the non-rebased PR: |
d6ca32f to
8df6bb1
Compare
This lint is on by default in >= Rust 1.88.0. We are currently unable to upgrade Rust version due to an unrelated issue, but add the lint to keep our code compliant and ready to upgrade once we can do so
fbe5278 to
1f4d722
Compare
I think I missed this because they were in benches or other code that is not "production". I also missed some in linux code since I'm running on my Macbook
1f4d722 to
929c26a
Compare
|
Reviewers - apologies for all the noise / pushes here. I ended up encountering instances in Linux, Solana, non-Unix and Windows target specific code which were not getting picked up when I was running on my Macbook. I'm going to bed but looks like I'll have finally gotten CI passing. I'd also be open to breaking this PR up into one PR for all the source changes, and another for the addition of the lint; lemme know what y'all think |
398f8f1 to
d392bbf
Compare
alexpyattaev
left a comment
There was a problem hiding this comment.
This LGTM, it is not particularly huge and does not have functional changes anyway.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7826 +/- ##
=======================================
Coverage 83.0% 83.0%
=======================================
Files 809 809
Lines 356483 356483
=======================================
+ Hits 296203 296221 +18
+ Misses 60280 60262 -18 🚀 New features to boost your workflow:
|
| --deny=clippy::default_trait_access \ | ||
| --deny=clippy::arithmetic_side_effects \ | ||
| --deny=clippy::manual_let_else \ | ||
| --deny=clippy::uninlined-format-args \ |
Problem
This lint is on by default in >= Rust 1.88.0. We are currently unable to upgrade Rust version due to an unrelated issue
Summary of Changes
Add the lint to keep our code compliant and ready to upgrade once we can do so
This PR was originally opened with items that are non-compliant to observe CI failures. Once #7825 merges and this PR is rebased, CI should complete without issueReferenced PR merged + this PR rebased