Skip to content

Resolving linter issue with keypair commenting#7870

Merged
roryharr merged 1 commit intoanza-xyz:masterfrom
roryharr:resolve_lint_keypair
Sep 3, 2025
Merged

Resolving linter issue with keypair commenting#7870
roryharr merged 1 commit intoanza-xyz:masterfrom
roryharr:resolve_lint_keypair

Conversation

@roryharr
Copy link
Copy Markdown

@roryharr roryharr commented Sep 3, 2025

Problem

  • linter is failing due to interleaved pulls
error: variables can be used directly in the `format!` string
   --> clap-utils/src/keypair.rs:185:43
    |
185 |                       std::io::Error::other(format!(
    |  ___________________________________________^
186 | |                         "No default signer found, run \"solana-keygen new -o {}\" to create a new \
187 | |                          one",
188 | |                         default_path
189 | |                     ))
    | |_____________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: requested on the command line with `-D clippy::uninlined-format-args`

Summary of Changes

  • Fix formatting to match expecations

Fixes #

@roryharr roryharr requested a review from steviez September 3, 2025 20:07
@roryharr roryharr marked this pull request as ready for review September 3, 2025 20:07
Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sake of papertrail, the PR that added the new lint was #7826. #7849 introduced the breaking change, but it was created before 7826 had been merged

@roryharr roryharr merged commit ea34d3b into anza-xyz:master Sep 3, 2025
40 of 43 checks passed
@roryharr
Copy link
Copy Markdown
Author

roryharr commented Sep 3, 2025

Going to squash and merge. It is getting further than before.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.0%. Comparing base (09d520c) to head (915b795).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7870     +/-   ##
=========================================
- Coverage    83.1%    83.0%   -0.1%     
=========================================
  Files         810      810             
  Lines      356624   356636     +12     
=========================================
- Hits       296382   296364     -18     
- Misses      60242    60272     +30     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KirillLykov KirillLykov mentioned this pull request Sep 4, 2025
KirillLykov added a commit that referenced this pull request Sep 4, 2025
* Revert "Resolving linter issue with keypair commenting (#7870)"

This reverts commit ea34d3b.

* Revert "fix: Show correct default path in signer error messages (#7849)"

This reverts commit 7c3e9e7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants