Skip to content

Finish clippy uninlined_format_args cleanup#7825

Merged
steviez merged 5 commits intoanza-xyz:masterfrom
steviez:clippy_finish_uninlined_format_args
Sep 2, 2025
Merged

Finish clippy uninlined_format_args cleanup#7825
steviez merged 5 commits intoanza-xyz:masterfrom
steviez:clippy_finish_uninlined_format_args

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Sep 2, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
    • These should only be instances of uninlined_format_args
  • Run cargo fmt with format_strings = true set in rustfmt.toml

We can't actually upgrade to Rust 1.88.0 (or later) yet, but a subsequent PR will add the lint to CI so that new instances are not reintroduced

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 33.85827% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.1%. Comparing base (0c3bf69) to head (1791793).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7825     +/-   ##
=========================================
- Coverage    83.1%    83.1%   -0.1%     
=========================================
  Files         808      808             
  Lines      356469   356479     +10     
=========================================
- Hits       296288   296238     -50     
- Misses      60181    60241     +60     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez marked this pull request as ready for review September 2, 2025 16:32
@steviez steviez requested review from a team as code owners September 2, 2025 16:32
@steviez steviez requested a review from brooksprumo September 2, 2025 16:32
brooksprumo
brooksprumo previously approved these changes Sep 2, 2025
@steviez
Copy link
Copy Markdown
Author

steviez commented Sep 2, 2025

I had just a couple more tweaks so sorry for the additions after requesting review. Also, I realize this PR is a bit of a mix, but it was few enough files/lines IMO to do as a single PR instead of doing per-crate-PR

Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the networking crates, specifically:
mock_alpenglow_consensus.rs
gossip
net-utils

Copy link
Copy Markdown

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steviez steviez merged commit fd07ce2 into anza-xyz:master Sep 2, 2025
43 checks passed
@steviez steviez deleted the clippy_finish_uninlined_format_args branch September 2, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants