Finish clippy uninlined_format_args cleanup#7825
Merged
steviez merged 5 commits intoanza-xyz:masterfrom Sep 2, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7825 +/- ##
=========================================
- Coverage 83.1% 83.1% -0.1%
=========================================
Files 808 808
Lines 356469 356479 +10
=========================================
- Hits 296288 296238 -50
- Misses 60181 60241 +60 🚀 New features to boost your workflow:
|
brooksprumo
previously approved these changes
Sep 2, 2025
Author
|
I had just a couple more tweaks so sorry for the additions after requesting review. Also, I realize this PR is a bit of a mix, but it was few enough files/lines IMO to do as a single PR instead of doing per-crate-PR |
brooksprumo
approved these changes
Sep 2, 2025
alexpyattaev
approved these changes
Sep 2, 2025
alexpyattaev
left a comment
There was a problem hiding this comment.
Checked the networking crates, specifically:
mock_alpenglow_consensus.rs
gossip
net-utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Working towards #6850, broken out from #6854
Summary of Changes
cargo clippy --fix --testswith Rust 1.88.0 set inrust-toolchain.tomluninlined_format_argscargo fmtwithformat_strings = trueset inrustfmt.tomlWe can't actually upgrade to Rust 1.88.0 (or later) yet, but a subsequent PR will add the lint to CI so that new instances are not reintroduced