Skip to content

Resolve Rust 1.88 clippy string lints and format strings (svm + misc)#6910

Merged
steviez merged 6 commits intoanza-xyz:masterfrom
steviez:rust_1.88_runtime
Jul 15, 2025
Merged

Resolve Rust 1.88 clippy string lints and format strings (svm + misc)#6910
steviez merged 6 commits intoanza-xyz:masterfrom
steviez:rust_1.88_runtime

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 10, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

  1. Set the Rust version to 1.88.0 (only temporarily, reverted after)
    channel = "1.87.0"
  2. Run cargo clippy --fix --tests
  3. Some manual cleanup on modified files

@steviez steviez requested a review from a team as a code owner July 10, 2025 05:20
@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 10, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

Comment thread programs/bpf_loader/src/syscalls/mod.rs
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@1e119f0). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6910   +/-   ##
=========================================
  Coverage          ?    83.2%           
=========================================
  Files             ?      853           
  Lines             ?   375928           
  Branches          ?        0           
=========================================
  Hits              ?   312953           
  Misses            ?    62975           
  Partials          ?        0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread platform-tools-sdk/cargo-build-sbf/src/main.rs Outdated
@steviez steviez force-pushed the rust_1.88_runtime branch from b4e998b to d1a05ce Compare July 10, 2025 16:07
@steviez steviez requested review from Lichtso and LucasSte July 11, 2025 22:45
Comment thread program-test/src/lib.rs Outdated
Comment thread program-test/src/lib.rs Outdated
Copy link
Copy Markdown
Author

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the items Lucas called out + force pushed to rebase on top of #6961

Comment thread program-test/src/lib.rs Outdated
Comment thread program-test/src/lib.rs Outdated
@steviez steviez requested a review from LucasSte July 15, 2025 05:53
@steviez steviez changed the title clippy: uninlined_format_args (runtime, svm and related) Resolve Rust 1.88 clippy string lints and format strings (svm + misc) Jul 15, 2025
LucasSte
LucasSte previously approved these changes Jul 15, 2025
Copy link
Copy Markdown
Author

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to force push to rebase on top of #6947

@steviez steviez requested a review from LucasSte July 15, 2025 17:01
@steviez steviez merged commit 2ac0e9c into anza-xyz:master Jul 15, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_runtime branch July 15, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants