Skip to content

programs: Resolve Rust 1.88 clippy lints and format strings#6961

Merged
steviez merged 2 commits intoanza-xyz:masterfrom
steviez:rust_1.88_programs
Jul 15, 2025
Merged

programs: Resolve Rust 1.88 clippy lints and format strings#6961
steviez merged 2 commits intoanza-xyz:masterfrom
steviez:rust_1.88_programs

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 14, 2025

Problem

Working towards #6850, broken out from #6910

Summary of Changes

For the programs directory:

  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
  • Run cargo fmt with format_strings = true set in rustfmt.toml

@steviez steviez requested a review from a team as a code owner July 14, 2025 18:58
@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 14, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.2%. Comparing base (4807a7a) to head (2d34383).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6961     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         856      856             
  Lines      376390   376402     +12     
=========================================
- Hits       313281   313269     -12     
- Misses      63109    63133     +24     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez merged commit a2c1e4c into anza-xyz:master Jul 15, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_programs branch July 15, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants