Skip to content

Move toolchain related functions to their own file in cargo-build-sbf#6947

Merged
LucasSte merged 3 commits intoanza-xyz:masterfrom
LucasSte:build-refactor
Jul 15, 2025
Merged

Move toolchain related functions to their own file in cargo-build-sbf#6947
LucasSte merged 3 commits intoanza-xyz:masterfrom
LucasSte:build-refactor

Conversation

@LucasSte
Copy link
Copy Markdown

@LucasSte LucasSte commented Jul 11, 2025

Problem

As suggested by @febo, I was changing the Solana toolchain name to 1.84.1-spbf-solana-v1.50 (<rust_version>-sbpf-solana-<platform_tools_version>), but I found that the file is very confusing since the toolchain functions are intertwined with the compilation steps.

Summary of Changes

This PR has no functional change. It puts the toolchain related functions into their own file.

@febo
Copy link
Copy Markdown

febo commented Jul 12, 2025

I was changing the Solana toolchain name to 1.84.1-solana-v1.50 (<rust_version>-solana-<platform_tools_version>)

I think we agreed on <rust_version>-sbpf-solana-<platform_tools_version> right?

@LucasSte
Copy link
Copy Markdown
Author

I was changing the Solana toolchain name to 1.84.1-solana-v1.50 (<rust_version>-solana-<platform_tools_version>)

I think we agreed on <rust_version>-sbpf-solana-<platform_tools_version> right?

Oh yes. I should have checked our conversation before typing the summary. My memory failed me.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (4807a7a) to head (494b290).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6947   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         856      856           
  Lines      376390   376390           
=======================================
+ Hits       313281   313311   +30     
+ Misses      63109    63079   -30     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucasSte LucasSte requested review from Lichtso and joncinque July 14, 2025 20:13
@LucasSte LucasSte marked this pull request as ready for review July 14, 2025 20:13
Copy link
Copy Markdown

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't take a close look at the logic, but the refactor makes sense to me!

@LucasSte LucasSte merged commit 9c6ff17 into anza-xyz:master Jul 15, 2025
42 checks passed
@LucasSte LucasSte deleted the build-refactor branch July 15, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants