Skip to content

clippy: manual_dangling_ptr#6912

Merged
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:rust_1.88_manual_dangling_ptr
Jul 10, 2025
Merged

clippy: manual_dangling_ptr#6912
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:rust_1.88_manual_dangling_ptr

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 10, 2025

Problem

Working towards #6850, broken out from #6910

Summary of Changes

Avoid the instance of manual_dangling_ptr; this lint was added in Rust 1.88:
https://rust-lang.github.io/rust-clippy/master/index.html#manual_dangling_ptr

@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 10, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@steviez
Copy link
Copy Markdown
Author

steviez commented Jul 10, 2025

The Firedancer team maintains a line-for-line reimplementation of the native programs, and until native programs are moved to BPF, those implementations must exactly match their Agave counterparts. If this PR represents a change to a native program implementation (not tests), please include a reviewer from the Firedancer team. And please keep refactors to a minimum.

Test code so no worries about this

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (96bef97) to head (00b535a).
⚠️ Report is 2938 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6912     +/-   ##
=========================================
- Coverage    83.3%    83.2%   -0.1%     
=========================================
  Files         853      853             
  Lines      377570   377570             
=========================================
- Hits       314525   314513     -12     
- Misses      63045    63057     +12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez merged commit ddefc13 into anza-xyz:master Jul 10, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_manual_dangling_ptr branch July 10, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants