v2.3: Remove debug-signature feature from transaction-context (backport of #6647)#6670
Merged
v2.3: Remove debug-signature feature from transaction-context (backport of #6647)#6670
Conversation
* remove debug-signature feat from transaction-context * missed one usage of the feature * remove from svm examples deps * one more missing lock file * missed usage of set_signature * sort deps for tx context (cherry picked from commit bd8ccc6) # Conflicts: # Cargo.toml
Author
|
Cherry-pick of bd8ccc6 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
t-nelson
approved these changes
Jun 20, 2025
Comment on lines
-111
to
+113
| solana-pubkey = { workspace = true, features = [ "rand" ] } | ||
| solana-pubkey = { workspace = true, features = ["rand"] } | ||
| solana-rent = { workspace = true } | ||
| solana-sbpf = { workspace = true } | ||
| solana-secp256k1-program = { workspace = true } | ||
| solana-secp256r1-program = { workspace = true, features = ["openssl-vendored"] } | ||
| solana-signature = { workspace = true, features = [ "rand" ] } | ||
| solana-signature = { workspace = true, features = ["rand"] } |
There was a problem hiding this comment.
is this cargo fmt or cargo sort being "helpful"?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.3 #6670 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 846 846
Lines 379283 379269 -14
=========================================
- Hits 314423 314388 -35
- Misses 64860 64881 +21 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This feature cannot reliably be filtered from release builds, so the quick solution that was discussed is to remove it
Summary of Changes
Remove usages of
solana_signature::Signature.This is an automatic backport of pull request #6647 done by [Mergify](https://mergify.com).