Skip to content

v2.3: Remove debug-signature feature from transaction-context (backport of #6647)#6670

Merged
mircea-c merged 3 commits intov2.3from
mergify/bp/v2.3/pr-6647
Jun 20, 2025
Merged

v2.3: Remove debug-signature feature from transaction-context (backport of #6647)#6670
mircea-c merged 3 commits intov2.3from
mergify/bp/v2.3/pr-6647

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Jun 20, 2025

Problem

This feature cannot reliably be filtered from release builds, so the quick solution that was discussed is to remove it

Summary of Changes

Remove usages of solana_signature::Signature.


This is an automatic backport of pull request #6647 done by [Mergify](https://mergify.com).

* remove debug-signature feat from transaction-context

* missed one usage of the feature

* remove from svm examples deps

* one more missing lock file

* missed usage of set_signature

* sort deps for tx context

(cherry picked from commit bd8ccc6)

# Conflicts:
#	Cargo.toml
@mergify mergify Bot requested a review from a team as a code owner June 20, 2025 14:04
@mergify mergify Bot added the conflicts label Jun 20, 2025
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Jun 20, 2025

Cherry-pick of bd8ccc6 has failed:

On branch mergify/bp/v2.3/pr-6647
Your branch is up to date with 'origin/v2.3'.

You are currently cherry-picking commit bd8ccc6a2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   programs/sbf/Cargo.lock
	modified:   svm/Cargo.toml
	modified:   svm/examples/Cargo.lock
	modified:   svm/src/transaction_processor.rs
	modified:   transaction-context/Cargo.toml
	modified:   transaction-context/src/lib.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Cargo.toml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot added the conflicts label Jun 20, 2025
Comment thread svm/Cargo.toml
Comment on lines -111 to +113
solana-pubkey = { workspace = true, features = [ "rand" ] }
solana-pubkey = { workspace = true, features = ["rand"] }
solana-rent = { workspace = true }
solana-sbpf = { workspace = true }
solana-secp256k1-program = { workspace = true }
solana-secp256r1-program = { workspace = true, features = ["openssl-vendored"] }
solana-signature = { workspace = true, features = [ "rand" ] }
solana-signature = { workspace = true, features = ["rand"] }
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this cargo fmt or cargo sort being "helpful"?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I ran cargo fmt

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (2e7c31e) to head (518bb00).

Additional details and impacted files
@@            Coverage Diff            @@
##             v2.3    #6670     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         846      846             
  Lines      379283   379269     -14     
=========================================
- Hits       314423   314388     -35     
- Misses      64860    64881     +21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't hurt to get a 👍 from @Lichtso, but removing the feature for simplicity seems reasonable to me

@mircea-c
Copy link
Copy Markdown

@steviez we have a review from SVM team on the original PR (#6647). I think that's good for our purposes.

@mircea-c mircea-c merged commit e3eca4c into v2.3 Jun 20, 2025
47 checks passed
@mircea-c mircea-c deleted the mergify/bp/v2.3/pr-6647 branch June 20, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants