Boxes rpc client_error::Error's ErrorKind field

[brooksprumo]

Problem

Issue #6278: The rpc client_error::Error struct triggers the result_large_err clippy lint. This is because the kind field is of type ErrorKind, which is 232 bytes. To fix this, and since this is only needed in the error case, we can box the ErrorKind.

Please see #6290 (comment) for the full context.

Summary of Changes

Boxes solana_rpc_client_api::client_error::Error's ErrorKind field, kind.

Important

Since the ErrorKind field is public and exported¹, this is an API-BREAKING CHANGE. As such, the earliest it can be merged is in v3.0.

Footnotes

1. https://docs.rs/solana-rpc-client-api/2.2.7/solana_rpc_client_api/client_error/struct.Error.html ↩

[mergify]

If this PR represents a change to the public RPC API:

1. Make sure it includes a complementary update to rpc-client/ (example)
2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @brooksprumo.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.8%. Comparing base (5f15e1f) to head (6778e53).
⚠️ Report is 3198 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #6293    +/-   ##
========================================
  Coverage    82.8%    82.8%            
========================================
  Files         847      847            
  Lines      379488   379488            
========================================
+ Hits       314367   314524   +157     
+ Misses      65121    64964   -157     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[steveluscher]

Yeah. I was wondering about that lint, but didn't know enough about Rust to assess the implications of acting on it.