Boxes inner tonic::Status inside BigTableError::Rpc#6624
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Jul 1, 2025
Merged
Boxes inner tonic::Status inside BigTableError::Rpc#6624brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo merged 1 commit intoanza-xyz:masterfrom
Conversation
brooksprumo
force-pushed
the
clippy/large-err/big-table
branch
from
eb25f68 to
59ac835
Compare
Author
|
Rebased because there have been a bunch of commits to master. |
steviez
approved these changes
Jul 1, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Technically a breaking change if someone is interacting with the error variants directly, but given that we're bumping the major to v3.0, I think we're cool with it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6624 +/- ##
=========================================
- Coverage 83.3% 83.3% -0.1%
=========================================
Files 853 853
Lines 378132 378132
=========================================
- Hits 315290 315260 -30
- Misses 62842 62872 +30 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #6278: The
BigTableErrortriggers theresult_large_errclippy lint. This is because a variant,Rpc, contains atonic::Status, which is 176 bytes. To fix this, and since this is only needed in the error case, we can box thetonic::Status.Similar to #6293.
Summary of Changes
Boxes inner tonic::Status inside BigTableError::Rpc.