Boxes inner SnapshotError in BankForksUtilsError::BankFromSnapshotsArchive

[brooksprumo]

Problem

Issue #6278: The BankForksUtilsError triggers the result_large_err clippy lint. This is because a variant, BankFromSnapshotsArchive, is too big. To fix this, and since this is only needed in the error case, we can box the inner SnapshotError (which is 80 bytes).

Similar to #6293.

Summary of Changes

Boxes inner SnapshotError.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.3%. Comparing base (af62b25) to head (6e16480).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master    #6625     +/-   ##
=========================================
- Coverage    83.3%    83.3%   -0.1%     
=========================================
  Files         853      853             
  Lines      378132   378132             
=========================================
- Hits       315290   315259     -31     
- Misses      62842    62873     +31     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bxczhu]

Hi team, can we merge this and unblock bumping rust to 1.87.0? Thanks!

[steviez]

Just the one question. Also, would you mind rekicking CI on this ? It has been sitting for a couple weeks (my fault, not yours) so just wanna make sure things haven't changed "under the hood".

Also, can you re-kick your other ones as well; I'll try to review those in quick succession after I see rebases

[brooksprumo]

Also, would you mind rekicking CI on this ? It has been sitting for a couple weeks (my fault, not yours) so just wanna make sure things haven't changed "under the hood".

Done!