Skip to content

Boxes PubsubClientError's ConnectionError and WsError#6610

Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:clippy/pubsub-client-error
Jun 17, 2025
Merged

Boxes PubsubClientError's ConnectionError and WsError#6610
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:clippy/pubsub-client-error

Conversation

@brooksprumo
Copy link
Copy Markdown

Problem

Issue #6278: The PubsubClientError triggers the result_large_err clippy lint. This is because two variants, ConnectionError and WsError, contain a tungstenite::Error, which is 136 bytes. To fix this, and since this is only needed in the error case, we can box the tungstenite::Error.

Similar to #6293.

Summary of Changes

Boxes PubsubClientError's ConnectionError and WsError, which both contain tungstenite::Error.

@brooksprumo brooksprumo self-assigned this Jun 16, 2025
@brooksprumo brooksprumo marked this pull request as ready for review June 16, 2025 20:46
@brooksprumo brooksprumo linked an issue Jun 16, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 16, 2025

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.8%. Comparing base (51c33c2) to head (e571361).
⚠️ Report is 3113 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6610     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         849      849             
  Lines      379159   379165      +6     
=========================================
- Hits       314069   314024     -45     
- Misses      65090    65141     +51     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200w-3941148729

@brooksprumo brooksprumo merged commit df94969 into anza-xyz:master Jun 17, 2025
28 checks passed
@brooksprumo brooksprumo deleted the clippy/pubsub-client-error branch June 17, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New result_large_err clippy lint blocks upgrading Rust to 1.87.0

3 participants