Boxes PubsubClientError's ConnectionError and WsError#6610
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Jun 17, 2025
Merged
Boxes PubsubClientError's ConnectionError and WsError#6610brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo merged 1 commit intoanza-xyz:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6610 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 849 849
Lines 379159 379165 +6
=========================================
- Hits 314069 314024 -45
- Misses 65090 65141 +51 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Issue #6278: The
PubsubClientErrortriggers theresult_large_errclippy lint. This is because two variants,ConnectionErrorandWsError, contain atungstenite::Error, which is 136 bytes. To fix this, and since this is only needed in the error case, we can box thetungstenite::Error.Similar to #6293.
Summary of Changes
Boxes PubsubClientError's ConnectionError and WsError, which both contain
tungstenite::Error.