Update maximum credits awarded per vote from 8 to 16#127
Update maximum credits awarded per vote from 8 to 16#127mergify[bot] merged 1 commit intoanza-xyz:masterfrom
Conversation
|
I optimistically added the CI label to this PR. However, it should be noted that this change will alter consensus; versions with / without the change will award different number of vote credits to voters ==> different account state ==> diverge due to accounts delta hash. If we end up accepting this PR, we should probably re-key the feature to avoid shooting ourselves in the foot with thinking that two versions are compatible when they really aren't. Granted the feature gate hasn't been activated, but when it does come time to activate, we might incorrectly assess the minimum required version. FYI @AshwinSekar - I think you hold the key / are a potential reviewer for this PR |
|
I agree with the proposal to re-key the feature. |
|
I agree with the re-keying, and we should backport this to 1.18 as well. Here's a new key: |
This reduces the maximum penalty for voting after the grace period by roughly 50%. This new value was derived from looking at the effects that TVC at max credits 8 would have for recent epochs (500+) and noting that the effect was a bit extreme, up to and exceeding 10% "bonus" for faster voters. This change reduces that maximum bonus by roughly half. In addition, the TVC feature key has been changed.
AshwinSekar
added
the
automerge
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
This reduces the maximum penalty for voting after the grace period by roughly 50%. This new value was derived from looking at the effects that TVC at max credits 8 would have for recent epochs (500+) and noting that the effect was a bit extreme, up to and exceeding 10% "bonus" for faster voters. This change reduces that maximum bonus by roughly half. In addition, the TVC feature key has been changed. (cherry picked from commit 940bd30)
This reduces the maximum penalty for voting after the grace period by roughly 50%. This new value was derived from looking at the effects that TVC at max credits 8 would have for recent epochs (500+) and noting that the effect was a bit extreme, up to and exceeding 10% "bonus" for faster voters. This change reduces that maximum bonus by roughly half. In addition, the TVC feature key has been changed.
5 participants
This reduces the maximum penalty for voting after the grace period by roughly 50%. This new value was derived from looking at the effects that TVC at max credits 8 would have for recent epochs (500+) and noting that the effect was a bit extreme, up to and exceeding 10% "bonus" for faster voters. This change reduces that maximum bonus by roughly half.