features: sync with agave#1700
Merged
Merged
Conversation
6788329 to
11d08dd
Compare
topointon-jump
previously requested changes
May 2, 2024
jumpsiegel
reviewed
May 2, 2024
Contributor
|
We cannot reorganize/cleanup this file without regenerating the native program tests... My suggestion is to try to limit the scope of the changes to the feature_map to changing the public keys and adding new things at the end |
b1161aa to
3dfa483
Compare
ripatel-fd
reviewed
May 3, 2024
ripatel-fd
requested changes
May 3, 2024
Contributor
topointon-jump
left a comment
There was a problem hiding this comment.
I think we need a way of distinguishing between "cleaned up" (removed after activation - hardcoded to default activated) and "removed" (anza has reverted the code for these features, and never activated them, so they are no longer even present in anza's feature gate list).
137e2b9 to
70c671c
Compare
c990127 to
2f3687c
Compare
jumpsiegel
previously approved these changes
May 17, 2024
ripatel-fd
previously approved these changes
May 17, 2024
Contributor
|
@lheeger-jump please fix CI |
Contributor
|
85c34cb to
de0f38a
Compare
56f3ca2 to
15967f6
Compare
bf12016 to
b1bcd78
Compare
jumpsiegel
approved these changes
May 30, 2024
topointon-jump
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated feature gates to stay in sync with agave:
"reverted":1the features that got deleted (never activated)Update
timely_vote_creditspubkey. Context: anza-xyz/agave#127Left as independent issue: #1906